Closed
Bug 602517
Opened 15 years ago
Closed 15 years ago
missing null check of xmodmap in [@ nsWindow::OnKeyPressEvent]
Categories
(Core Graveyard :: Widget: Qt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: timeless, Assigned: timeless)
Details
(Keywords: coverity, crash)
Crash Data
Attachments
(1 file)
|
1023 bytes,
patch
|
dougt
:
review+
dougt
:
approval2.0+
|
Details | Diff | Splinter Review |
1336 nsEventStatus
1337 nsWindow::OnKeyPressEvent(QKeyEvent *aEvent)
1338 {
1364 XModifierKeymap *xmodmap = XGetModifierMapping(display);
1371 for (int i = 0; i < 8 * xmodmap->max_keypermod; ++i) {
1592 if (xmodmap) {
1593 XFreeModifiermap(xmodmap);
|
||
Updated•15 years ago
|
Assignee: nobody → jeremias.bosch
http://mxr.maemo.org/fremantle/source/libx11/src/ModMap.c#36 shows that it can fail.
i don't have a compiler handy here (on osx), but this should be correct
Assignee: mkristoffersen → timeless
Status: NEW → ASSIGNED
Attachment #496393 -
Flags: review?(doug.turner)
Attachment #496393 -
Flags: approval2.0?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 496393 [details] [diff] [review]
never compiled
npodb
Attachment #496393 -
Flags: review?(doug.turner)
Attachment #496393 -
Flags: review+
Attachment #496393 -
Flags: approval2.0?
Attachment #496393 -
Flags: approval2.0+
Keywords: checkin-needed
|
||
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•15 years ago
|
Crash Signature: [@ nsWindow::OnKeyPressEvent]
|
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•