[Mac default] MailNews (tab)scrollbox arrows/buttons needs love

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
The current ones looks quite ugly:

- there's no hover/hover:active state (which would be nice in this case since it'll match the tabs)
- there's no border separating the button from the tab
- the disabled one is smaller than the normal one
(Assignee)

Comment 1

7 years ago
Created attachment 481589 [details] [diff] [review]
make it look better

I think this looks much better. The arrows are taken from mail/, they took it from Firefox (but Firefox doesn't use them anymore). Originally, it was 2 sets of 4 images, but I don't think anyone used all 4. I have removed the ones we don't use, so we now only have 2 sets of 2 images.

Note btw, that we don't want the directions to be swapped in rtl. TB seems to do that, but I think that's wrong.
Attachment #481589 - Flags: superreview?(neil)
Attachment #481589 - Flags: review?(mnyromyr)
(Assignee)

Updated

7 years ago
Target Milestone: --- → seamonkey2.1b2
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

7 years ago
Created attachment 481590 [details]
Screenshots before/after

Here are some screenshots of before/after the patch.
(Assignee)

Comment 3

7 years ago
Note btw that I make the whole border transparent in the disabled state. I figured that looked nicer, since I would otherwise have tab and button border next to each other.

Comment 4

7 years ago
(In reply to comment #1)
> The arrows are taken from mail/
Can't we hg copy them in that case?
(Assignee)

Comment 5

7 years ago
(In reply to comment #4)
> (In reply to comment #1)
> > The arrows are taken from mail/
> Can't we hg copy them in that case?

Ah, yes, of course - for some reason I didn't thought of that.

Comment 6

7 years ago
Comment on attachment 481589 [details] [diff] [review]
make it look better

sr=me if the images are hg copied.
Attachment #481589 - Flags: superreview?(neil) → superreview+
(Assignee)

Updated

7 years ago
Blocks: 593840
(Assignee)

Comment 7

7 years ago
Neil was ok with not hg copying the images since I've changed them anyway.

Updated

7 years ago
Attachment #481589 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 8

7 years ago
http://hg.mozilla.org/comm-central/rev/b8e41a21ce1f
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.