The current ones looks quite ugly: - there's no hover/hover:active state (which would be nice in this case since it'll match the tabs) - there's no border separating the button from the tab - the disabled one is smaller than the normal one
I think this looks much better. The arrows are taken from mail/, they took it from Firefox (but Firefox doesn't use them anymore). Originally, it was 2 sets of 4 images, but I don't think anyone used all 4. I have removed the ones we don't use, so we now only have 2 sets of 2 images. Note btw, that we don't want the directions to be swapped in rtl. TB seems to do that, but I think that's wrong.
Note btw that I make the whole border transparent in the disabled state. I figured that looked nicer, since I would otherwise have tab and button border next to each other.
(In reply to comment #1) > The arrows are taken from mail/ Can't we hg copy them in that case?
(In reply to comment #4) > (In reply to comment #1) > > The arrows are taken from mail/ > Can't we hg copy them in that case? Ah, yes, of course - for some reason I didn't thought of that.
Comment on attachment 481589 [details] [diff] [review] make it look better sr=me if the images are hg copied.
Attachment #481589 - Flags: superreview?(neil) → superreview+
Neil was ok with not hg copying the images since I've changed them anyway.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.