Last Comment Bug 602568 - [Mac default] MailNews (tab)scrollbox arrows/buttons needs love
: [Mac default] MailNews (tab)scrollbox arrows/buttons needs love
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: x86 Mac OS X
-- normal (vote)
: seamonkey2.1b2
Assigned To: Stefan [:stefanh]
Depends on:
Blocks: 593840
  Show dependency treegraph
Reported: 2010-10-07 10:51 PDT by Stefan [:stefanh]
Modified: 2010-10-31 12:45 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

make it look better (7.01 KB, patch)
2010-10-07 11:35 PDT, Stefan [:stefanh]
mnyromyr: review+
neil: superreview+
Details | Diff | Splinter Review
Screenshots before/after (22.43 KB, image/png)
2010-10-07 11:37 PDT, Stefan [:stefanh]
no flags Details

Description User image Stefan [:stefanh] 2010-10-07 10:51:05 PDT
The current ones looks quite ugly:

- there's no hover/hover:active state (which would be nice in this case since it'll match the tabs)
- there's no border separating the button from the tab
- the disabled one is smaller than the normal one
Comment 1 User image Stefan [:stefanh] 2010-10-07 11:35:34 PDT
Created attachment 481589 [details] [diff] [review]
make it look better

I think this looks much better. The arrows are taken from mail/, they took it from Firefox (but Firefox doesn't use them anymore). Originally, it was 2 sets of 4 images, but I don't think anyone used all 4. I have removed the ones we don't use, so we now only have 2 sets of 2 images.

Note btw, that we don't want the directions to be swapped in rtl. TB seems to do that, but I think that's wrong.
Comment 2 User image Stefan [:stefanh] 2010-10-07 11:37:22 PDT
Created attachment 481590 [details]
Screenshots before/after

Here are some screenshots of before/after the patch.
Comment 3 User image Stefan [:stefanh] 2010-10-07 11:42:36 PDT
Note btw that I make the whole border transparent in the disabled state. I figured that looked nicer, since I would otherwise have tab and button border next to each other.
Comment 4 User image 2010-10-07 16:41:38 PDT
(In reply to comment #1)
> The arrows are taken from mail/
Can't we hg copy them in that case?
Comment 5 User image Stefan [:stefanh] 2010-10-08 03:58:22 PDT
(In reply to comment #4)
> (In reply to comment #1)
> > The arrows are taken from mail/
> Can't we hg copy them in that case?

Ah, yes, of course - for some reason I didn't thought of that.
Comment 6 User image 2010-10-08 08:51:00 PDT
Comment on attachment 481589 [details] [diff] [review]
make it look better

sr=me if the images are hg copied.
Comment 7 User image Stefan [:stefanh] 2010-10-09 14:05:59 PDT
Neil was ok with not hg copying the images since I've changed them anyway.
Comment 8 User image Stefan [:stefanh] 2010-10-31 12:45:55 PDT

Note You need to log in before you can comment on or make changes to this bug.