602568 - [Mac default] MailNews (tab)scrollbox arrows/buttons needs love

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

The current ones looks quite ugly:

- there's no hover/hover:active state (which would be nice in this case since it'll match the tabs)
- there's no border separating the button from the tab
- the disabled one is smaller than the normal one

Comment 1

[Stefan [:stefanh]]

Attachment: make it look better

I think this looks much better. The arrows are taken from mail/, they took it from Firefox (but Firefox doesn't use them anymore). Originally, it was 2 sets of 4 images, but I don't think anyone used all 4. I have removed the ones we don't use, so we now only have 2 sets of 2 images.

Note btw, that we don't want the directions to be swapped in rtl. TB seems to do that, but I think that's wrong.

Comment 2

[Stefan [:stefanh]]

Attachment: Screenshots before/after

Here are some screenshots of before/after the patch.

Comment 3

[Stefan [:stefanh]]

Note btw that I make the whole border transparent in the disabled state. I figured that looked nicer, since I would otherwise have tab and button border next to each other.

Comment 4

[[e-mail]]

(In reply to comment #1)
> The arrows are taken from mail/
Can't we hg copy them in that case?

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)
> (In reply to comment #1)
> > The arrows are taken from mail/
> Can't we hg copy them in that case?

Ah, yes, of course - for some reason I didn't thought of that.

Comment 6

[[e-mail]]

Comment on attachment 481589 [details] [diff] [review]
make it look better

sr=me if the images are hg copied.

Comment 7

[Stefan [:stefanh]]

Neil was ok with not hg copying the images since I've changed them anyway.

Comment 8

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/b8e41a21ce1f