602786 - lirasm: fix trivial Windows test failure

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Description

[Nicholas Nethercote [inactive]]

We currently get this:

  TEST-UNEXPECTED-FAIL | lirasm | lirasm  --execute ../nanojit-src/lirasm/tests/hardfloat/ui2d.in
  expected output
  Output is: 4.29497e+09
  actual output
  Output is: 4.29497e+009

That's really annoying.  We currently use |cout << d| to print the double result.  Anyone know if printf("%f") or printf("%g") gives more consistent results across all platforms?

Comment 1

[Rick Reitmaier]

Looks like we won't be able to eliminate compiler/lib differences, but I wonder if post-processing is a feasible option.

Comment 2

[Rick Reitmaier]

Attachment: sed to the rescue

Not pretty but should do the job to make windows happy.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 487469 [details] [diff] [review]
sed to the rescue

r=me if you add a brief comment explaining why the sed command is there.  Thanks!

Comment 4

[Rick Reitmaier]

rreitmai http://hg.mozilla.org/projects/nanojit-central/rev/fa319402f3bb

Comment 5

[Rick Reitmaier]

(In reply to comment #4)
> rreitmai http://hg.mozilla.org/projects/nanojit-central/rev/fa319402f3bb

Gak, change applied to input file, not output... fix coming.

Comment 6

[Rick Reitmaier]

Ignore comment 5, the problem was cygwin sed's treatment of escape.

fix in http://hg.mozilla.org/projects/nanojit-central/rev/cf0963c16a8c

Comment 7

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/104e20381ef1
http://hg.mozilla.org/tracemonkey/rev/2b77342e96dd
http://hg.mozilla.org/tracemonkey/rev/a23a09d2a9b6

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/a23a09d2a9b6