60289 - ::first-letter doesn't get margin-right applied

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect, P3)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   Try to apply margin-right to the ::first-letter pseudo-element.

ACTUAL RESULTS
   T'is ignored.

Tested with Win32 Netscape commercial trunk build 2000111120.

Comment 1

[Hixie (not reading bugmail)]

Attachment: Simple and self explanatory testcase.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Please triage.

Comment 3

[joki (gone)]

We'll start with the style system.

Comment 4

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 5

[Pierre Saslawsky]

The style data is correct.  Reassigned to Layout.

Note: margin-left works fine, which is more important than margin-right for the 
first-letter.  Low priority.

Comment 6

[Pierre Saslawsky]

Really reassigning to Layout...

Comment 7

[Marc Attinasi]

Moving Mozilla 1.01 bugs to 'future' milestone with priority P1

I will be pulling bugs from 'future' milestones when scheduling later work.

Comment 8

[Greg K.]

Confirming problem using FizzillaCFM/2002061014. Marking All/All. 

Comment 9

[Chris Petersen]

Still occurs in the OS X 2002-07-31-05 NB.

Comment 10

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 11

[Boris Zbarsky [:bzbarsky]]

I'm not sure why this is correct... is there a reason first-letter frames claim
to be incomplete?

Comment 12

[rbs]

Comment on attachment 166639 [details] [diff] [review]
Patch rev. 1

Patch looks ok. r=rbs if you instead test |pfd->GetFlag(PFD_ISLETTERFRAME)|
which is a quick flag set in that circumstance.

-----------
The reason why first-letter claims to be incomplete is because it indeed chops
just the first letter, and so only accounts for that part of the text content.

What worried me at first was why the patch wouldn't mess the other
continuations (since all of them are letterframes... but styled with the parent
context per nsFirstLetterFrame::Init)? 

I was expecting this test:

    if (NS_FRAME_IS_NOT_COMPLETE(aStatus) &&
	!pfd->GetFlag(PFD_ISLETTERFRAME) && !HasPrevInFlow(pfd->mFrame) {


But inspection showed that |ApplyStartMargin| (already) zeroes the margin of
the continutations if need be. So the patch looks fine to me.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 166639 [details] [diff] [review]
Patch rev. 1

sr=dbaron (with rbs's PFD_ISLETTERFRAME comment fixed)

Comment 14

[Mats Palmgren (inactive)]

(In reply to comment #12) 
> But inspection showed that |ApplyStartMargin| (already) zeroes the margin of
> the continutations if need be. So the patch looks fine to me.

Note that this is unnecessary in the case of a first-letter continuation
though, since it has a different style context which never has a margin AFAIK.
(i.e. ResolveStyleForNonElement(parentStyleContext))

FWIW, I have also checked that it works fine with bug 45091, where a
::first-letter element may be comprised of several independant first-letter
frames (each with continuations) and only the last "owns" the right margin.
In this case the "intermediate" margins are killed off in the reflow state.

I'm unsure if it will work when ::first-letters eventually will be nested
as well (bug 214004), but I will not worry about that now...

Comment 15

[Mats Palmgren (inactive)]

Attachment: What was checked in

Comment 16

[Mats Palmgren (inactive)]

Checked in 2004-11-27 18:17 PDT.

-> FIXED