603005 - HUDService should avoid the use of DOM mutation event listeners

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

The HUDService adds a DOMNodeInserted handler to the outputNode to detect messages being added to check whether they need to be filtered. That makes all DOM mutations on the chrome document slower than they need to be. It should do the filtering before the element is added to the output node (I realize there may be multiple callers...) rather than relying on a DOM mutation event.

Comment 1

[Patrick Walton (:pcwalton)]

(In reply to comment #0)
> The HUDService adds a DOMNodeInserted handler to the outputNode to detect
> messages being added to check whether they need to be filtered. That makes all
> DOM mutations on the chrome document slower than they need to be. It should do
> the filtering before the element is added to the output node (I realize there
> may be multiple callers...) rather than relying on a DOM mutation event.

This will be easier to do after the console styling output patch is done. One of the side effects of this patch is that all messages will be routed through a common output function.

Alternately, we could fix up and land bug 578658.

Comment 2

[Patrick Walton (:pcwalton)]

This is fixed in my patch queue for bug 605621.

Comment 3

[Patrick Walton (:pcwalton)]

Fixed in the patch attached to bug 605621.

Comment 4

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 5

[Kevin Dangoor]

mass change: filter mail on BLOCKERSETTING

Comment 6

[Dão Gottwald [:dao]]

Kevin: You're abusing the bug severity field. It's not supposed to mirror the release-blocking state.

Comment 7

[Kevin Dangoor]

Dao: sorry about that. I didn't realize that people were relying on that field for other metrics and such.

Comment 8

[Rob Campbell [:rc] (:robcee)]

fixed by landing of patch in bug 605621