Closed
Bug 603041
Opened 14 years ago
Closed 14 years ago
Fix reading-data example test
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
0.9
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
1.48 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Whoops, I broke the reading-data test in bug 594076. Failure shows up in Matej's logs in bug 602870 and bug 602869.
Attachment #481998 -
Flags: review?(myk)
Comment 1•14 years ago
|
||
Comment on attachment 481998 [details] [diff] [review]
patch
>+ /* the id is randomly generated during tests, so we cannot compare it
>+ against anything in particular. Just assert that it is not empty. */
Nits, while you're here:
the id -> The ID
. Just -> . Just (two spaces between period ending sentence and first
word of next sentence in monospaced code comments.)
>+ "resource://reading-data-reading-data-data/sample.html");
reading-data-reading-data-data?! :-)
Attachment #481998 -
Flags: review?(myk) → review+
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> >+ "resource://reading-data-reading-data-data/sample.html");
>
> reading-data-reading-data-data?! :-)
Totally grody!
http://hg.mozilla.org/labs/jetpack-sdk/rev/c64901992d5c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: -- → 0.9
Comment 3•14 years ago
|
||
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.
To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•