Closed Bug 603066 Opened 9 years ago Closed 7 years ago

Path in shell\open\command registry key in installer SetAsDefault function should be quoted

Categories

(SeaMonkey :: Installer, defect)

x86
Windows XP
defect
Not set

Tracking

(seamonkey2.15 fixed)

RESOLVED FIXED
seamonkey2.15
Tracking Status
seamonkey2.15 --- fixed

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

Attachments

(2 files)

I noticed the path to the application in the shell\open\command registry key does not get quoted (for example below the StartMenuInternet key). This should be changed as an application can also be installed in a path containing a space.
Attached patch Firefox patchSplinter Review
Assignee: nobody → bugzilla
Attachment #482026 - Flags: review?(rstrong)
Attachment #482026 - Flags: review?(rstrong) → review?(robert.bugzilla)
Attached patch SeaMonkey PatchSplinter Review
Attachment #482028 - Flags: review?(bugzilla)
(In reply to comment #0)
> I noticed the path to the application in the shell\open\command registry key
> does not get quoted (for example below the StartMenuInternet key). This should
> be changed as an application can also be installed in a path containing a
> space.
These specific paths only need to be quoted if they have command line arguments.
Attachment #482026 - Flags: review?(robert.bugzilla) → review-
Assignee: bugzilla → installer
Component: NSIS Installer → Installer
Product: Toolkit → SeaMonkey
QA Contact: nsis.installer → xpi-packages
Guess I'll have to investigate this further then. I discovered this bug after setting SeaMonkey as default browser when the path to seamonkey.exe contained spaces (I got "(Null) not a valid win32 application" after clicking on the Internet start menu entry). Then I added quotes around the path in shell\open\command and it worked fine. Maybe something else triggered that as on another PC (same OS, same service pack) it seems to work fine with spaces inside the path.
There is nothing wrong with adding quotes but it definitely isn't required for these keys and Firefox has been doing it this way iirc since the 2.0 cycle without a single bug report.
Ok, I found out what is causing this, it's a Windows bug and me having tested something else a few weeks ago: The path to my SeaMonkey installation was C:\Documents and Settings\Frank\Desktop\.... . I had also created a file with the name "Documents" on the drive C:. After renaming (or deleting) that file it worked again. So yeah, it's a special case :)
Comment on attachment 482028 [details] [diff] [review]
SeaMonkey Patch

Cancelling review until the Firefox side is sorted.
Attachment #482028 - Flags: review?(bugzilla)
The Firefox side is sorted IMHO, it's a bug(?) or a feature in Windows, see Comment 6. The quotes are needed.
Comment on attachment 482028 [details] [diff] [review]
SeaMonkey Patch

The quotes are needed, see Comment 6 and http://msdn.microsoft.com/en-us/library/windows/desktop/cc144109%28v=vs.85%29.aspx on this:
"Use quotation marks appropriately to ensure that spaces in the command line are not misinterpreted. [...] Note that in this value, quotation marks are placed around the path because it contains embedded spaces. Omitting these quotation marks could cause the command line to be misinterpreted."
Attachment #482028 - Flags: review?(philip.chee)
Comment on attachment 482028 [details] [diff] [review]
SeaMonkey Patch

rs=me based on code inspection. I assume that you've tested this patch!
Attachment #482028 - Flags: review?(philip.chee) → review+
Tested the patch and works fine. Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/05edecfafc41
Assignee: installer → bugzilla
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Settings flags to make tracking of fixed bugs easier.
Target Milestone: --- → seamonkey2.15
You need to log in before you can comment on or make changes to this bug.