603066 - Path in shell\open\command registry key in installer SetAsDefault function should be quoted

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

I noticed the path to the application in the shell\open\command registry key does not get quoted (for example below the StartMenuInternet key). This should be changed as an application can also be installed in a path containing a space.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Firefox patch

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: SeaMonkey Patch

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #0)
> I noticed the path to the application in the shell\open\command registry key
> does not get quoted (for example below the StartMenuInternet key). This should
> be changed as an application can also be installed in a path containing a
> space.
These specific paths only need to be quoted if they have command line arguments.

Comment 4

[Frank Wein [:mcsmurf]]

Guess I'll have to investigate this further then. I discovered this bug after setting SeaMonkey as default browser when the path to seamonkey.exe contained spaces (I got "(Null) not a valid win32 application" after clicking on the Internet start menu entry). Then I added quotes around the path in shell\open\command and it worked fine. Maybe something else triggered that as on another PC (same OS, same service pack) it seems to work fine with spaces inside the path.

Comment 5

[Robert Strong (they/them - no direct email)]

There is nothing wrong with adding quotes but it definitely isn't required for these keys and Firefox has been doing it this way iirc since the 2.0 cycle without a single bug report.

Comment 6

[Frank Wein [:mcsmurf]]

Ok, I found out what is causing this, it's a Windows bug and me having tested something else a few weeks ago: The path to my SeaMonkey installation was C:\Documents and Settings\Frank\Desktop\.... . I had also created a file with the name "Documents" on the drive C:. After renaming (or deleting) that file it worked again. So yeah, it's a special case :)

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 482028 [details] [diff] [review]
SeaMonkey Patch

Cancelling review until the Firefox side is sorted.

Comment 8

[Frank Wein [:mcsmurf]]

The Firefox side is sorted IMHO, it's a bug(?) or a feature in Windows, see Comment 6. The quotes are needed.

Comment 9

[Frank Wein [:mcsmurf]]

Comment on attachment 482028 [details] [diff] [review]
SeaMonkey Patch

The quotes are needed, see Comment 6 and http://msdn.microsoft.com/en-us/library/windows/desktop/cc144109%28v=vs.85%29.aspx on this:
"Use quotation marks appropriately to ensure that spaces in the command line are not misinterpreted. [...] Note that in this value, quotation marks are placed around the path because it contains embedded spaces. Omitting these quotation marks could cause the command line to be misinterpreted."

Comment 10

[Philip Chee]

Comment on attachment 482028 [details] [diff] [review]
SeaMonkey Patch

rs=me based on code inspection. I assume that you've tested this patch!

Comment 11

[Frank Wein [:mcsmurf]]

Tested the patch and works fine. Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/05edecfafc41

Comment 12

[Frank Wein [:mcsmurf]]

Settings flags to make tracking of fixed bugs easier.