603133 - All 1.9.1 tests broken unpacking tests

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

See, for example, http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.5/1286673046.1286673071.15808.gz

unpack mochitest tests exception
=== Output ===
(crapload of CSS and HTML)
<type 'exceptions.ValueError'>: Don't know how to handle firefox-3.5.15pre.en-US.linux-i686.tests.tar.bz2
Traceback (most recent call last):
  File "/builds/buildbot/build_master4/lib/python2.6/site-packages/buildbot-0.8.1-py2.6.egg/buildbot/process/buildstep.py", line 720, in startStep
    d.addCallback(self._startStep_2)
  File "/builds/buildbot/build_master4/lib/python2.6/site-packages/twisted/internet/defer.py", line 224, in addCallback
    callbackKeywords=kw)
  File "/builds/buildbot/build_master4/lib/python2.6/site-packages/twisted/internet/defer.py", line 213, in addCallbacks
    self._runCallbacks()
  File "/builds/buildbot/build_master4/lib/python2.6/site-packages/twisted/internet/defer.py", line 371, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
--- <exception caught here> ---
  File "/builds/buildbot/build_master4/lib/python2.6/site-packages/buildbot-0.8.1-py2.6.egg/buildbot/process/buildstep.py", line 755, in _startStep_2
    skip = self.start()
  File "/builds/buildbot/build_master4/lib/python2.6/site-packages/buildbotcustom/steps/misc.py", line 437, in start
    raise ValueError("Don't know how to handle %s" % filename)
exceptions.ValueError: Don't know how to handle firefox-3.5.15pre.en-US.linux-i686.tests.tar.bz2
=== Output ended ===
I take it nobody actually looked at Firefox3.5 (before or) after the "only unpack the tests we need for a suite" patch landed?

Comment 1

[Phil Ringnalda (:philor)]

I closed the 1.9.1 tree.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Syed, could you please look at this ? The basic problem is that 1.9.1 still uses bz2 compression for test archives, and everything else moved to zip files.

Comment 3

[Syed Albiz [:salbiz]]

Attachment: fall back to default unpackFile behaviour for tarballs [Tested]

I didn't realize we were using tarballs for any of the tests and neglected to account for that in my patch. This patch simply falls back to the previous behaviour and unpacks the whole thing if it comes across a tarball during unpackTest. Alternatively, I could also re-factor the logic to selectively unpack tests for both tarballs and zips, but that will require a bit more testing to make sure everything works properly.

Comment 4

[Syed Albiz [:salbiz]]

Comment on attachment 482546 [details] [diff] [review]
fall back to default unpackFile behaviour for tarballs [Tested]

Did a quick staging run to make sure it works.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 482546 [details] [diff] [review]
fall back to default unpackFile behaviour for tarballs [Tested]

http://hg.mozilla.org/build/buildbotcustom/rev/a6ac1ffd5e79

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Lots of green tests on Firefox3.5 now.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Reopened 3.5 tree too.