603211 - Fix test: browser_webconsole_bug_595350_multiple_windows_and_tabs.js

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

This test fails and/or asserts, needs a re-factor. For one, it can probably only use 1 additional tab, as I do not see the benefit of using 3.

So the test should be: open 2 tabs, log and check output.
open a new window with 1 tab, log and check output, close window, log more messages and check output.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Proposed fix.

Please note that there's a small fix for head.js to not close the last tab, when the test that just executed already does that. The browser_webconsole_bug_595350_multiple_windows_and_tabs.js test file needs to close the tabs it opens to check after that the state of the HUDService. If head.js closes the last tab, then the last window also closes, which breaks all other tests. So, the simple fix is to close all tabs, except the last one. No regressions are caused by this small change.

Comment 2

[David Dahl :ddahl]

Comment on attachment 483134 [details] [diff] [review]
proposed fix

nice catch in head.js

Comment 3

[David Dahl :ddahl]

I can push this without review as it is a test change. Let me do some testing first.

Comment 4

[Mihai Sucan [:msucan]]

Adding checkin-needed, given it's only a test change.

Comment 5

[Mihai Sucan [:msucan]]

Attachment: [checked-in] rebased patch and fixed for the compartments landing

Patch fixed for the compartments landing.

Comment 6

[Rob Campbell [:rc] (:robcee)]

this requires review.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 484057 [details] [diff] [review]
[checked-in] rebased patch and fixed for the compartments landing

Looks like you can remove this test from the comment at the end of head.js as well.

The other head.js change makes me wonder what the effect these console tests have on the state of the browser during the test run. Not related to this bug in any way, but it'd be an interesting experiment to write code that logs of event listeners added/nodes in document/etc. to see how the browser's state changes during mochitest/browserchrome/etc. test runs.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 484057 [details] [diff] [review]
[checked-in] rebased patch and fixed for the compartments landing

http://hg.mozilla.org/mozilla-central/rev/4da5ab8255ec