603213 - Rename MailNews-related ToC entries that only refer to Mail in their title

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

This bug is about adding " & Newsgroups" to those Help table of contents entries that only contain "Mail" in their title despite their content referring to all sorts of account types or the whole MailNews module. "Using Mail" and "Getting Started with Mail" are two examples (maybe the only ones).

See bug 246405 comments 140-143 for the reasoning.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Rename MailNews-related ToC entries that only refer to Mail in their title. (v1)

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 539736 [details] [diff] [review]
Rename MailNews-related ToC entries that only refer to Mail in their title. (v1)

Review of attachment 539736 [details] [diff] [review]:
-----------------------------------------------------------------

Will check later if there are more cases when I'm back home.

::: suite/locales/en-US/chrome/common/help/suite-toc.rdf
@@ +12,4 @@
>          <rdf:li> <rdf:Description ID="help-help" nc:name="Using the Help Window" nc:link="help_help.xhtml"/> </rdf:li>
>          <rdf:li> <rdf:Description ID="ieusers"/> </rdf:li>
>          <rdf:li> <rdf:Description ID="nav" nc:name="Browsing the Web" nc:link="nav_help.xhtml"/> </rdf:li>
> +        <rdf:li> <rdf:Description ID="mail" nc:name="Using Mail &amp; NewsGroups" nc:link="mailnews_getting_started.xhtml"/> </rdf:li>

We're no using CamelCase for /everything/, you know. ;-) SeaMonkey and MailNews, but not Newsgroups, not NewsGroups.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 539736 [details] [diff] [review]
Rename MailNews-related ToC entries that only refer to Mail in their title. (v1)

Two more occurrences in suite-toc.rdf:
1. Setting Up Mail to Work Offline
2. General Mail Shortcuts

Please fix those, too. There are more matches in help-index1.rdf, but that's beyond this bug (affects only searches, not the ToC) and we might just leave it as it is.

r- for the moment; mainly because I want to see a new patch.

I found one more thing. You may consider to fix it here or we can open a new bug for it; your choice:

We have some places where the trailing "s" is missing after "Mail & Newsgroup":
1. "Mail & Newsgroup Preferences" (suite-toc.rdf, mailnews_preferences.xhtml; no need to change the ID)
2. "Mail & Newsgroup Account Settings" (three occurrences in mailnews_account_settings.xhtml)

Comment 4

[Edmund Wong (:ewong)]

Attachment: Rename MailNews-related ToC entries that only refer to Mail in their title. (v2)

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 539974 [details] [diff] [review]
Rename MailNews-related ToC entries that only refer to Mail in their title. (v2)

You missed "Mail & Newsgroup Preferences" in mailnews_preferences.xhtml. r=me with that.

Comment 6

[Edmund Wong (:ewong)]

Attachment: Rename MailNews-related ToC entries that only refer to Mail in their title. (v3) [Checkin: comments 7 and 9]

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 540047 [details] [diff] [review]
Rename MailNews-related ToC entries that only refer to Mail in their title. (v3) [Checkin: comments 7 and 9]

http://hg.mozilla.org/comm-central/rev/aeb02008b00f

Feel free to request aurora/beta approval, both of which are currently closed.

Comment 8

[Robert Kaiser]

Comment on attachment 540047 [details] [diff] [review]
Rename MailNews-related ToC entries that only refer to Mail in their title. (v3) [Checkin: comments 7 and 9]

For Aurora, that's probably OK, but we're shipping the beta build today that we consider more or less the real RC for 2.2, so I don't feel like we should take it there (Council members, please let me know if you disagree, I'm only one of the collective nowadays).

Comment 9

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 540047 [details] [diff] [review]
Rename MailNews-related ToC entries that only refer to Mail in their title. (v3) [Checkin: comments 7 and 9]

http://hg.mozilla.org/releases/comm-aurora/rev/d8ffaea3495a