Closed Bug 603243 Opened 10 years ago Closed 8 years ago

remove pitfall nsTString_CharT(char_type c) constructor

Categories

(Core :: String, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: vlad, Assigned: atulagrwl)

Details

Attachments

(1 file)

This constructor is a great pitfall, because it's very tempting to write code like this:

  int len = ...;
  ...
  nsCAutoString str(len);
  SomeMethod(str.BeginWriting());

  str(len) doesn't even show a warning, which I don't quite understand, since it's a narrower type.  Would be nice to run an analysis to see where the (char) form is used and if we can just get rid of them, then just get rid of this constructor -- or perhaps make it do the more useful thing (capacity len, length 0).
I just tried commenting this ctor out, as well as making it private, and both compile fine on debug Linux.  Want to just do a tryserver run with it private or removed, and if that passes push it?
It's used by xpcom/tests/TestTArray.cpp but that appears to only be included in the Makefile in a disable libxul build.
So if it's not actually used -- what about actually making it do the more useful thing, making it equivalent to str.SetCapacity(len) ?  Though you'd still need to remember to call SetLength after writing to it, so maybe just getting rid of it is best.

I'll make a patch and fix up TestTArray.cpp.
Attached patch Patch v1Splinter Review
Removing the culprit ctor. I didn't get any failure so I am assuming TestTArray.cpp file has changed.
https://tbpl.mozilla.org/?tree=Try&rev=2d768e29de54
Attachment #574912 - Flags: review?(dbaron)
Comment on attachment 574912 [details] [diff] [review]
Patch v1

r=dbaron
Attachment #574912 - Flags: review?(dbaron) → review+
Keywords: checkin-needed
Assignee: nobody → atulagrwl
https://hg.mozilla.org/mozilla-central/rev/346e090f5a4d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.