Closed Bug 603265 Opened 12 years ago Closed 11 years ago

Importing a .cvf with empty lines doesn't work

Categories

(MailNews Core :: Import, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 15.0

People

(Reporter: Usul, Assigned: leon.sha)

References

Details

Attachments

(1 file)

In bug 600798 there are two vcard that are suposed to work with the code added in bug 79709. The first one works, the second one doesn't.

Files can be found at http://hg.mozilla.org/qa/litmus-data/file/947e21f848da/thunderbird/import the emptylines_vcard_addressbook.vcf is the faulty file.
OS: Mac OS X → All
Duplicate of this bug: 674841
Attached patch patchSplinter Review
Filter out the empty line.
Attachment #622993 - Flags: review?
Attachment #622993 - Flags: review? → review?(dbienvenu)
Assignee: nobody → leon.sha
Status: NEW → ASSIGNED
Hardware: x86 → All
Comment on attachment 622993 [details] [diff] [review]
patch

you could instead use do while and pass in aMore directly to ReadLine, so the code would look like this:

do {
  rv = aLineStream->ReadLine(line, aMore);
}
while (line.IsEmpty() && *aMore);
if (!*aMore)
  return rv;
Attachment #622993 - Flags: review?(dbienvenu) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.