603312 - unreachable return this in TIntermConstantUnion::fold

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[timeless]

988 TIntermTyped* TIntermConstantUnion::fold(TOperator op, TIntermTyped* constantNode, TInfoSink& infoSink)
989 {
993     if (constantNode) {  // binary operations
1245         return tempNode;
1246     } else {
1277         return newNode;
1278     }

this line is unreachable:
1280     return this;
1281 }

Comment 1

[timeless]

Attachment: patch for reference (i'll send upstream in a bit)

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

-> INVALID, upstream code as you say -- we don't want to diverge from upstream to fix stuff trivial stuff like this, especially when upstream is being actively developed.