603364 - my_proto is unused in testClassGetter_isCalled

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

54 BEGIN_TEST(testClassGetter_isCalled)
55 {
56     JSObject *my_proto;
57 
58     my_proto = JS_InitClass(cx, JS_GetGlobalObject(cx), NULL, &ptestClass, PTest, 0,
59                             NULL, ptestFunctions, NULL, NULL);
60 
61     EXEC("function check() { var o = new PTest(); o.test_fn(); o.test_value1; o.test_value2; o.test_value1; }");
62 
63     for (int i = 1; i < 9; i++) {
64         jsvalRoot rval(cx);
65         CHECK(JS_CallFunctionName(cx, global, "check", 0, NULL, rval.addr()));
66         CHECK_SAME(INT_TO_JSVAL(called_test_fn), INT_TO_JSVAL(i));
67         CHECK_SAME(INT_TO_JSVAL(called_test_prop_get), INT_TO_JSVAL(4 * i));
68     }
69     return true;
70 }
71 END_TEST(testClassGetter_isCalled)

-- yes, I know it's a test. The coverity instance I have isn't smart enough to ignore those, and I can't see a reason you wouldn't want to make my_proto used.

Comment 1

[timeless]

Attachment: patch

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 483789 [details] [diff] [review]
patch

I'll land this today.

Comment 3

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/16483461f359

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/16483461f359