Closed Bug 603373 Opened 15 years ago Closed 15 years ago

Remove unused library argument of NS_TRY_SAFE_CALL_* macros.

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch fix v1.0 (obsolete) — Splinter Review
The argument is unused and AFAICS can be safely removed.
Attachment #482256 - Attachment is patch: true
Attachment #482256 - Flags: review?(joshmoz)
Attached patch fix v1.1 (obsolete) — Splinter Review
On second thought, GetLibrary calls are still needed for validating PluginFuncs() result.
Assignee: nobody → jacek
Attachment #482256 - Attachment is obsolete: true
Attachment #482467 - Flags: review?(joshmoz)
Attachment #482256 - Flags: review?(joshmoz)
Comment on attachment 482467 [details] [diff] [review] fix v1.1 >- PluginLibrary* library = mPlugin->GetLibrary(); >- if (!library) >- return NS_ERROR_FAILURE; >- > NPPluginFuncs* pluginFunctions = mPlugin->PluginFuncs(); According to 'nsNPAPIPlugin' documentation, "PluginFuncs() can't fail but results are only valid if GetLibrary() succeeds". Don't remove that check. >- PluginLibrary* library = mPlugin->GetLibrary(); >- if (!library) >- return NS_ERROR_FAILURE; >- > NPPluginFuncs* pluginFunctions = mPlugin->PluginFuncs(); Same thing a little later on in the patch. Thanks for the cleanup.
Attachment #482467 - Flags: review?(joshmoz) → review-
Attached patch fix v1.2Splinter Review
Thanks for the review. I somehow missed these two places, sorry. The attached version fixes the problem.
Attachment #482467 - Attachment is obsolete: true
Attachment #483138 - Flags: review?(joshmoz)
Attachment #483138 - Flags: review?(joshmoz) → review+
Attachment #483138 - Flags: approval2.0?
Attachment #483138 - Flags: approval2.0? → approval2.0+
Depends on: 604768
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: