603373 - Remove unused library argument of NS_TRY_SAFE_CALL_* macros.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

The argument is unused and AFAICS can be safely removed.

Comment 1

[Jacek Caban]

Attachment: fix v1.1

On second thought, GetLibrary calls are still needed for validating PluginFuncs() result.

Comment 2

[Josh Aas]

Comment on attachment 482467 [details] [diff] [review]
fix v1.1

>-  PluginLibrary* library = mPlugin->GetLibrary();
>-  if (!library)
>-    return NS_ERROR_FAILURE;
>-
>   NPPluginFuncs* pluginFunctions = mPlugin->PluginFuncs();

According to 'nsNPAPIPlugin' documentation, "PluginFuncs() can't fail but results are only valid if GetLibrary() succeeds". Don't remove that check.

>-  PluginLibrary* library = mPlugin->GetLibrary();
>-  if (!library)
>-    return NS_ERROR_FAILURE;
>-
>   NPPluginFuncs* pluginFunctions = mPlugin->PluginFuncs();

Same thing a little later on in the patch.

Thanks for the cleanup.

Comment 3

[Jacek Caban]

Attachment: fix v1.2

Thanks for the review. I somehow missed these two places, sorry. The attached version fixes the problem.

Comment 4

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/2f23afd0b705