Closed
Bug 603373
Opened 14 years ago
Closed 14 years ago
Remove unused library argument of NS_TRY_SAFE_CALL_* macros.
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file, 2 obsolete files)
15.25 KB,
patch
|
jaas
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
The argument is unused and AFAICS can be safely removed.
Assignee | ||
Updated•14 years ago
|
Attachment #482256 -
Attachment is patch: true
Attachment #482256 -
Flags: review?(joshmoz)
Assignee | ||
Comment 1•14 years ago
|
||
On second thought, GetLibrary calls are still needed for validating PluginFuncs() result.
Assignee: nobody → jacek
Attachment #482256 -
Attachment is obsolete: true
Attachment #482467 -
Flags: review?(joshmoz)
Attachment #482256 -
Flags: review?(joshmoz)
Comment on attachment 482467 [details] [diff] [review] fix v1.1 >- PluginLibrary* library = mPlugin->GetLibrary(); >- if (!library) >- return NS_ERROR_FAILURE; >- > NPPluginFuncs* pluginFunctions = mPlugin->PluginFuncs(); According to 'nsNPAPIPlugin' documentation, "PluginFuncs() can't fail but results are only valid if GetLibrary() succeeds". Don't remove that check. >- PluginLibrary* library = mPlugin->GetLibrary(); >- if (!library) >- return NS_ERROR_FAILURE; >- > NPPluginFuncs* pluginFunctions = mPlugin->PluginFuncs(); Same thing a little later on in the patch. Thanks for the cleanup.
Attachment #482467 -
Flags: review?(joshmoz) → review-
Assignee | ||
Comment 3•14 years ago
|
||
Thanks for the review. I somehow missed these two places, sorry. The attached version fixes the problem.
Attachment #482467 -
Attachment is obsolete: true
Attachment #483138 -
Flags: review?(joshmoz)
Attachment #483138 -
Flags: review?(joshmoz) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #483138 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #483138 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2f23afd0b705
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•