603406 - domNode viewer assumes some non-element nodes are element nodes

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Colby Russell :crussell (no longer Mozilla-ing)]

Attachment: hide the tree for and disable Insert for non-elements [Checkin: comment 5]

The attribute tree is only relevant if the node is an element.  Similarly cmdEditInsert should only be enabled if the node is an element.

Comment 1

[Alex Vincent [:WeirdAl]]

crussell: Would it be worth preserving cmdEditInsert support for document fragment nodes?  (Granted, it's not easy to get one into DOM Inspector...)

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

(In reply to comment #1)
> crussell: Would it be worth preserving cmdEditInsert support for document
> fragment nodes?  (Granted, it's not easy to get one into DOM Inspector...)

It's not that hard to get one; we "export" inspectObject in hooks.js for anybody to use.  That'll give you an object viewer inspecting whatever you pass in.

But document fragments can't have attributes anyway.

Comment 3

[Alex Vincent [:WeirdAl]]

Oh, sorry.  I thought cmdEditInsert was about inserting child nodes, not attributes.

Comment 4

[[e-mail]]

Comment on attachment 482288 [details] [diff] [review]
hide the tree for and disable Insert for non-elements [Checkin: comment 5]

I figured out when Insert used to be erroneously enabled.

Comment 5

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 482288 [details] [diff] [review]
hide the tree for and disable Insert for non-elements [Checkin: comment 5]

Pushed: http://hg.mozilla.org/dom-inspector/rev/911d1a632765