603416 - startup crash [@ cal::UTC()]

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Wayne Mery (:wsmwk)]

crash [@ cal::UTC()]
~ #125 crash rank for thunderbird v3.1.4
approx 1/2 are startup crashes

bp-8287c4c3-a198-4083-a0d8-14de92101006
0	calbscmp.dll	cal::UTC	calendar/base/src/calUtils.h:143
1	calbscmp.dll	calDateTime::Reset	calendar/base/src/calDateTime.cpp:139
2	calbscmp.dll	calDateTime::calDateTime	calendar/base/src/calDateTime.cpp:67
3	calbscmp.dll	calDateTimeConstructor	calendar/base/build/calBaseModule.cpp:65
4	calbscmp.dll	nsGenericFactory::CreateInstance	xpcom/glue/nsGenericFactory.cpp:80
5	xpcom_core.dll	nsComponentManagerImpl::CreateInstance	xpcom/components/nsComponentManager.cpp:1597
6	thunderbird.exe	nsJSCID::CreateInstance	js/src/xpconnect/src/xpcjsid.cpp:821
7	xpcom_core.dll	NS_InvokeByIndex_P	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
8	thunderbird.exe	XPCWrappedNative::CallMethod	js/src/xpconnect/src/xpcwrappednative.cpp:2722
9	thunderbird.exe	XPC_WN_CallMethod	js/src/xpconnect/src/xpcwrappednativejsops.cpp:1740
10	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1360
11	js3250.dll	js_Interpret	js/src/jsops.cpp:2240
12	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1368
13	js3250.dll	js_fun_apply	js/src/jsfun.cpp:2046
14	js3250.dll	js_Interpret	js/src/jsops.cpp:2208
15	js3250.dll	js_Invoke	js/src/jsinterp.cpp:1368
16	js3250.dll	js_InternalInvoke	js/src/jsinterp.cpp:1423
17	js3250.dll	JS_CallFunction	js/src/jsapi.cpp:5114
18	thunderbird.exe	nsJSContext::CallEventHandler	dom/base/nsJSEnvironment.cpp:2177
19	thunderbird.exe	nsJSEventListener::HandleEvent	dom/src/events/nsJSEventListener.cpp:269
20	thunderbird.exe	nsEventListenerManager::HandleEventSubType	content/events/src/nsEventListenerManager.cpp:1041

bp-c5e88d02-6cd5-40d5-b277-3936f2100927 has an email address

Comment 1

[timeless]

141 inline nsCOMPtr<calITimezone> UTC() {
142 nsCOMPtr<calITimezone> tz;
143 getTimezoneService()->GetUTC(getter_AddRefs(tz)); 

according to the report, getTimezoneService() returned null

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Hmm strange. I wonder how that happened. wsmwk, could you ask the reporter if there were any error console messages beforehand and if he can reproduce this bug?

Comment 3

[Wayne Mery (:wsmwk)]

I've posted to the user. No response yet.

no other crashes have email addresses. :(

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Unfortunately it seems this has become a topcrasher for 1.0b4. Can someone with a debugger reproduce this under windows?

Comment 5

[Wayne Mery (:wsmwk)]

I ran a crash stats mail campaign #61 asking for help with debug - it sent maybe 30 messages for 711 crash reports

Comment 6

[Rain [:rain1] (inactive)]

I have a feeling this is some sort of reentrancy/initialization cycle bug, where https://mxr.mozilla.org/comm-central/source/calendar/base/src/calTimezoneService.js#112 in the timezone service constructor causes that UTC function to be called. Consider initializing it lazily.

Comment 7

[Wayne Mery (:wsmwk)]

FWIW, crashes go back at least as far as 1.0b1, per bp-326c7e84-f9ed-49f3-b98c-ef9252101022

bp-9131ccb2-84ad-4e3e-92b0-0dd922100611 comment is "using ctrl-shift-c to start Calendar"

ran socorro Campaign 62 https://crash-stats.mozilla.com/admin/email_campaign/62

Comment 8

[Wayne Mery (:wsmwk)]

campaign 62 didn't email anyone due to current constraints for https://wiki.mozilla.org/PostCrash - so it is probably not possible to email any more until the system is revised (per rhelmer)

Comment 9

[Ludovic Hirlimann [:Usul]]

Here are the instructions for catching the stack trace in the debugger : https://developer.mozilla.org/en/how_to_get_a_stacktrace_with_windbg if you catch this please comment on the bug so fallen can ask you more information.

Comment 10

[Rain [:rain1] (inactive)]

I'm not sure about comment 6 any more...

bp-8d63ede4-08a5-4282-8038-4a2792110707 is a 5.0 crash report -- the stack's somewhat different from the earlier ones, more involved.

Comment 11

[Rain [:rain1] (inactive)]

This might be a broken stack though -- see bp-dd881af3-8da8-49c6-aa3c-aeacf2110707 -- don't see how one could jump from AddRef to js::Interpret...

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

So on a debug build, when typing top.opener.cal.getTimezoneService().UTC in the error console, I get 4 "undefined reference" messages and then the reult is correctly shown (linux). This could have to do with that.

I'll put up a patch that guards the c++ side of things from crashes and initializes the internal timezones lazily, lets see if it helps.

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Intermediate Fix - v1

This patch won't save the user from a crash, but it will crash more controlled and notify the user why its crashing. It also includes lazily initializing UTC and floating, I'll test this on the other box that has the previously mentioned symptoms.

Comment 14

[Philipp Kewisch [:Fallen][📱📆]]

Ok, had access to my windows box now. I tried a few things, but couldn't reproduce with any of the following steps (all without the patch):

* Since this has to do with UTC, create an event in the UTC timezone
* Single alarm, recurring alarm, any alarm (in UTC) 
* Set CPU affinity to only one processor

I've also tested this patch on the debug build that produces "undefined reference"  messages (and then succeeds nevertheless!!?) but it didn't help.

I think the best we can do is apply the patch here and wait for crash feedback. Unless someone else can reliably reproduce this?

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

I found someone who has entered his Email in bp-c13bbd89-ae87-4f4d-93eb-f6d352110703 and have contacted him to receive more information.

Comment 16

[Philipp Kewisch [:Fallen][📱📆]]

Ok, I have another idea how we can fix this:

In the constructor to calDateTime.cpp, Reset() is called. This sets the timezone to UTC, which is very likely the reason for this crash. We could lazily initialize the timezone (i.e set to null and then add checks that set to UTC later on if null. I'll put up a patch that combines the above and this idea.

Comment 17

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

Ok, this should take care. I'd appreciate anyones review so we can get this out of the door as fast as possible.

Also, I'd appreciate testing to make sure this doesn't break anything. Possible scenarios:

* Recurring events with alarms
* Recurring events with exceptions
* Events in local time (that should not become UTC events)
* Events in UTC

Comment 18

[Martin Schröder [:mschroeder]]

Comment on attachment 545133 [details] [diff] [review]
Fix - v2

This looks good codewise! We should spin a RC with this fix included, and do a official call for testing. r=mschroeder

Comment 19

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/741351000bdf>
-> FIXED

Comment 20

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/13276b2cc970>

Comment 21

[Philipp Kewisch [:Fallen][📱📆]]

Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/7663efa8deb9>

Comment 22

[Philipp Kewisch [:Fallen][📱📆]]

The BOM I accidentally introduced with the above patch has been removed in various changesets.

Comment 23

[Martin Schröder [:mschroeder]]

My error console shows following messages directly after start up (with 1.0b5rc1 on Mac):

Warning: reference to undefined property getTimezoneService().defaultTimezone
Source File: chrome://calendar/content/calUtils.js
Line: 219

Warning: reference to undefined property getTimezoneService().defaultTimezone
Source File: resource://calendar/modules/calUtils.jsm -> file:///Users/mschroeder/Library/Thunderbird/Profiles/s4p58ovy.a-profile/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js
Line: 219

Warning: reference to undefined property getTimezoneService().UTC
Source File: resource://calendar/modules/calUtils.jsm -> file:///Users/mschroeder/Library/Thunderbird/Profiles/s4p58ovy.a-profile/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js
Line: 200

Warning: reference to undefined property getTimezoneService().floating
Source File: resource://calendar/modules/calUtils.jsm -> file:///Users/mschroeder/Library/Thunderbird/Profiles/s4p58ovy.a-profile/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js
Line: 208

Comment 24

[Stefan Sitter [:ssitter]]

The strict warnings appear all the time in 1.0b4 release and older nightly builds, i.e. they are not related to the patch in this bug. They will be repeated hundred times if you do some basic testing.

Comment 25

[Philipp Kewisch [:Fallen][📱📆]]

Yeah, I haven't found out why they appear, nor how to get them away. The funny thing is, if you evaluate the properties in the error console, the correct value is returned but the messages show up nevertheless.