60344 - Mozilla calls my Inbox `INBOX'

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect, P2)

Description

[Matthew T (active 1999-2002)]

Build: 2000111520, Mac OS 9.0

My IMAP Inbox appears to be called `INBOX' on the IMAP server. As a result, it is 
displayed not as `Inbox' but as `INBOX', and this looks corny.

Assuming that IMAP folder names are case-insensitive, I suggest that any folder 
name which is all capitals on the server should be treated by Mozilla (and 
recorded in Mozilla's mail database) as if it had only an initial capital.

Comment 1

[tenthumbs]

If I remember right, only INBOX is case-insensitive.

Comment 2

[David :Bienvenu]

yes, only INBOX is case-insensitive - your suggestion is not viable for all
folders in general. You, as a user, have control over the case of your other
folder names. We present the INBOX name as the IMAP server presents it to us.

Comment 3

[David :Bienvenu]

this should be fairly trivial to fix.

Comment 4

[scottputterman]

marking nsbeta1-

Comment 5

[David :Bienvenu]

It might be mozilla calling your Inbox INBOX and your server might be calling it
Inbox - Navin has a fix if that's the problem

Comment 6

[Navin Gupta]

Attachment: proposed fix.

Comment 7

[Navin Gupta]

Use the boxname as sent by the server instead of "INBOX". Need review, david 

Comment 8

[David :Bienvenu]

r=bienvenu, though judging by that fix, 4.x would have had the same problem,
wouldn't it?

Comment 9

[Navin Gupta]

mpt, could you verify this patch or tell us the server where we can verify it ?

I don't know what 4x does ? I think it would always create "Inbox", no matter
what. 

Comment 10

[Matthew T (active 1999-2002)]

Sorry, I don't currently have the setup to apply patches. Mozilla has this
problem (and 4.x does not) with all IMAP accounts I have had; one of these is
mailandnews.com, which offers free IMAP accounts so you can get one there and
try it out.

If the server itself refers to the inbox as INBOX, I still think it would be
preferable from an aesthetic point of view to display it as `Inbox' -- provided
that it is not possible for an IMAP server to have two folders named `Inbox' and
`INBOX' at the same time.

Comment 11

[Navin Gupta]

mpt, the mailandnews server sends INBOX. From the log

ask for all mailboxes
268[396b340]: mailandnews.com:A:SendData: 3 lsub "" "*"^M
The server replies
268[396b340]: mailandnews.com:A:CreateNewLineFromSocket: * LSUB () "." Deleted^M
268[396b340]: mailandnews.com:A:CreateNewLineFromSocket: * LSUB () "." INBOX^M
268[396b340]: mailandnews.com:A:CreateNewLineFromSocket: * LSUB () "." Outbox^M
268[396b340]: mailandnews.com:A:CreateNewLineFromSocket: * LSUB () "." Trash^M
268[396b340]: mailandnews.com:A:CreateNewLineFromSocket: 3 OK Completed^M

Comment 12

[Navin Gupta]

I think what mpt is suggesting here is to change INBOX to Inbox, just like in
4x. right ?

Comment 13

[Matthew T (active 1999-2002)]

Right.

Comment 14

[Gervase Markham [:gerv]]

So the patch we want is one which uses the string "Inbox" whether the server
sends "inbox", "INBOX" or "Inbox", right?

If this is the case, it's a tiny mod to the attached patch.

Gerv

Comment 15

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Comment 16

[Gervase Markham [:gerv]]

Looking for some rubberstamps here, please... This is a one-liner. blake?
bienvenu? naving?
Gerv

Comment 17

[Navin Gupta]

We cannot take this patch because there are several other places where we call
Inbox "INBOX". This will need some more work. 

Comment 18

[Gervase Markham [:gerv]]

I've done an LXR search for all occurrences of the string "INBOX" and have only
found the following ones which seemed possibly relevant:
mailnews/imap/src/nsImapServerResponseParser.cpp, line 840 -- boxname =
PL_strdup("INBOX");
mailnews/imap/src/nsIMAPHostSessionList.cpp, line 704 --
result.AppendWithConversion("INBOX");
mailnews/imap/src/nsImapIncomingServer.cpp, line 1088 -- PRInt32 offset =
parentName.Find("INBOX",PR_TRUE,0,1); 
mailnews/imap/src/nsImapProtocol.cpp, line 5821 -- List("INBOX", PR_TRUE);

The first one is the one changed in the current patch. I've checked the others
out and, as far as I can see, none of them seem relevant. Note that this change
is only meant to affect the displayed string; all internal handling should
continue as before.

Also, please note that the original fix which you attached to this bug, which
uses what the server sends instead of INBOX (whereas my fix uses "Inbox" instead
of "INBOX") only changes this file.

If you think there are other files that need changing, you are going to have to
give me a clue as to what they are ;-)

Gerv

Comment 19

[Blake Ross]

Didn't make the 0.9.3 train.

Comment 20

[Håkan Waara]

I think Gerv's patch look reasonable, to separate backend and frontend usage of
this constant. I asked him to test it on IRC, and he said it works too.

If you get bienvenu's sr, here's r=hwaara.

Comment 21

[David :Bienvenu]

I thought we already checked in a fix for this, and we had some problem with
Cyrus servers because we changed the case of INBOX which messed up sub-folders.
Navin, do you have the bug I'm talking about?

Comment 22

[Navin Gupta]

Gervase, I remember telling you that this bug is trivial and may cause 
more problems than good. Please do not checkin this fix. Inbox is a 
very sensitive folder and we need to be sure that it works in all cases with
different servers. I cannot test it right now but I will get to it in mach V. 

bienvenu, that is a different bug, I have that bug.

Comment 23

[Håkan Waara]

mach V?

Comment 24

[Gervase Markham [:gerv]]

Navin: I am happy to hold off if you are going to get to this eventually.
Otherwise, I'd like to keep investigating and testing. 

It either causes problems or it doesn't - if all we change is the displayed
string, it can't cause problems. If that string is used for other things
internally, it may cause problems and we should find a fix that only changes the
displayed string.

Gerv

Comment 25

[Gervase Markham [:gerv]]

I may try and move the string change closer to the actual point of display, to
avoid any suggestion that it will mess with other internal stuff.

Gerv

Comment 26

[R.K.Aa.]

*** Bug 90683 has been marked as a duplicate of this bug. ***

Comment 27

[Karen Huang]

Ccing Cavin

Comment 28

[Karen Huang]

Cavin, do you think this bug is related to bug 98433 that I logged?
Looks like we are still having problem for Inbox  & INBOX for
interoperability......

Comment 29

[Navin Gupta]

Karen, this bug is different from bug 98433  

Comment 30

[Martin Sillence]

Please note that bug 90683  marked as a duplicate is about cyrus imap server
being case _sensitive_ to the name of Inbox when there are subfolders of Inbox.
Where as the original report is about Inbox being case insensitive.

I'm not sure but it looks like the proposed fix should solve this?

Comment 31

[Håkan Waara]

A suggestion would be to have a hardcoded #define somewhere for the case of
inbox (that would be "Inbox") and then use it everywhere. That would solve
naving's concerns of inconsistency, right?

Comment 32

[Gervase Markham [:gerv]]

I don't have the energy for this any more. It's a trivial cosmetic fix, and I
can't be bothered to fight past all the obstacles.

Gerv

Comment 33

[scottputterman]

moving to 0.9.9

Comment 34

[Navin Gupta]

this was fixed when I fixed bug 57440

Comment 35

[Navin Gupta]

marking fixed

Comment 36

[Karen Huang]

Matthew, can you confirm this bug's fix?
Please mark as verified if the problem is not occurring for your IMAP Server.
Thanks.