603508 - make nsConnectionEntry persistent for pipelines

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, enhancement)

Description

[Patrick McManus [:mcmanus]]

under the pipelining project the nsConnectionEntry object has been annotated with all kinds of interesting information about the pipelining success and failures of each host. Rather than relearning that information on each start it would be good to make it persistent - especially the information on failures.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch v1

store penalty data (both global host and classification based) along with the associated ttls, and the results of the pipeline startup test and static host blacklist it brings.. if privatebrowsing has been witnessed, then don't write out any penalty data as it implies a browsing history - but its ok to do the pretest information as that isn't personal at all. Add prefs for controlling the ttl of the pretest and host based blacklist information

Comment 2

[Patrick McManus [:mcmanus]]

Attachment: patch v2

fix bug involving opening DB off of main thread

Comment 3

[Patrick McManus [:mcmanus]]

Attachment: patch v3

update bitrot, confrom better to style guide, updates based on experience (i.e. bugs and tweaks), etc..

Comment 4

[Patrick McManus [:mcmanus]]

Attachment: patch v4

Comment 5

[Patrick McManus [:mcmanus]]

Attachment: patch 5

bitrot

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 542087 [details] [diff] [review]
patch 5

Dropping the review request now.

I can see some issues with this particular patch after a first look.  When anyone interested after this bug gets actual again I can publish them in detail.

This is also a potential candidate to be based on LevelDB.  I would really like to avoid adding new sqlite dbs.

Comment 7

[Patrick McManus [:mcmanus]]

if anything - we will rip out pipelines