Closed Bug 603508 Opened 12 years ago Closed 7 years ago

make nsConnectionEntry persistent for pipelines

Categories

(Core :: Networking: HTTP, enhancement)

x86_64
Linux
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

Attachments

(1 file, 4 obsolete files)

under the pipelining project the nsConnectionEntry object has been annotated with all kinds of interesting information about the pipelining success and failures of each host. Rather than relearning that information on each start it would be good to make it persistent - especially the information on failures.
Attached patch patch v1 (obsolete) — Splinter Review
store penalty data (both global host and classification based) along with the associated ttls, and the results of the pipeline startup test and static host blacklist it brings.. if privatebrowsing has been witnessed, then don't write out any penalty data as it implies a browsing history - but its ok to do the pretest information as that isn't personal at all. Add prefs for controlling the ttl of the pretest and host based blacklist information
Attachment #487943 - Flags: review?(honzab.moz)
Attached patch patch v2 (obsolete) — Splinter Review
fix bug involving opening DB off of main thread
Attachment #487943 - Attachment is obsolete: true
Attachment #490092 - Flags: review?(honzab.moz)
Attachment #487943 - Flags: review?(honzab.moz)
Attached patch patch v3 (obsolete) — Splinter Review
update bitrot, confrom better to style guide, updates based on experience (i.e. bugs and tweaks), etc..
Attachment #490092 - Attachment is obsolete: true
Attachment #495146 - Flags: review?(honzab.moz)
Attachment #490092 - Flags: review?(honzab.moz)
Depends on: 632496
Blocks: 603514
No longer blocks: 603514
Depends on: 603514
Attached patch patch v4 (obsolete) — Splinter Review
Attachment #495146 - Attachment is obsolete: true
Attachment #513676 - Flags: review?(honzab.moz)
Attachment #495146 - Flags: review?(honzab.moz)
Attached patch patch 5Splinter Review
bitrot
Attachment #513676 - Attachment is obsolete: true
Attachment #542087 - Flags: review?(honzab.moz)
Attachment #513676 - Flags: review?(honzab.moz)
Comment on attachment 542087 [details] [diff] [review]
patch 5

Dropping the review request now.

I can see some issues with this particular patch after a first look.  When anyone interested after this bug gets actual again I can publish them in detail.

This is also a potential candidate to be based on LevelDB.  I would really like to avoid adding new sqlite dbs.
Attachment #542087 - Flags: review?(honzab.moz)
if anything - we will rip out pipelines
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.