603518 - If no tabs are sync'd, integrated Sync UI should not show device name

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tony Chung [:tchung]]

Attachment: No Tabs in Desktop Screenshot

The device name is appearing in the Integrated Sync UI even though there are no tabs that are sync'd in that account.   We should hide these accounts from the Desktop View in these situations.

See screenshot.  "suckahhhh" is an account on another device with no open tabs

Repro:
1) install fennec nightly on maemo and android: 
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101011 Firefox/4.0b8pre Fennec/4.0b2pre	
or 
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101011 Firefox/4.0b8pre Fennec/4.0b2pre	
2) Sync an account with no tabs 
3) Open account on a fennec device, and click tabs from other computers or Desktop from awesomescreen
4) Verify the Sync'd account with no tabs open displays the Device name, but no tabs

Expected:
- if the sync account has no open tabs, then we should not display the device at all in the Desktop view

ActuaL:
- see screenshot.  device name is present in the list

Comment 1

[Stuart Parmenter]

Madhava, what do you want us to do here?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I thought there was another bug (a dupe of this) somewhere. We decided to just hide computers that have no open tabs, which can happen with old, unused computers or devices.

Sync has no way yet to drop those devices from your account.

Comment 3

[[:fabrice] Fabrice Desré]

Attachment: patch

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Fabrice - you can land stuff now, right? :)

Comment 5

[[:fabrice] Fabrice Desré]

Pushed :
http://hg.mozilla.org/mobile-browser/rev/8e32f711ac82

Comment 6

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID Central: 
Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110513 Firefox/6.0a1 Fennec/6.0a1  

Build ID Aurora:
Mozilla /5.0 (Android;Linux armv7l;rv:5.0a1) Gecko/20110512 Firefox/5.0a2 Fennec/5.0a2 

Device : HTC Desire Z (Android 2.2)