603675 - Test failure in testUndoTabFromContextMenu.js | testTabbedBrowsingAPI (default)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

MODULES: firefox/testSessionStore/testUndoTabFromContextMenu.js
TEST: testUndoTabFromContextMenu.js
ERROR: Controller.assertJSProperty(ID: context_undoCloseTab) : true == false
BRANCH: default

We seem to be opening navigation bar context menu when we want to be opening the tab bar context menu. Changing the targeted element to 'tabs_strip' still produces this issue.

Side note: The assert should also be changed to assertDOMProperty.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That's exactly the bug Jeff is catching with in the last day on a box beside his desktop. Interesting that it now also appears on brasstacks. It still works fine locally. So this is getting more interesting.

(In reply to comment #0)
> Side note: The assert should also be changed to assertDOMProperty.

No, there is no disabled property attached to the DOM. It's a property of the JS object. And instead of the strip we should also right click the first tab. The strip itself will not show the tab context menu.

Comment 2

[Jeff Hammel]

(In reply to comment #0)
> MODULES: firefox/testSessionStore/testUndoTabFromContextMenu.js
> TEST: testUndoTabFromContextMenu.js
> ERROR: Controller.assertJSProperty(ID: context_undoCloseTab) : true == false
> BRANCH: default
> 
> We seem to be opening navigation bar context menu when we want to be opening
> the tab bar context menu. Changing the targeted element to 'tabs_strip' still
> produces this issue.
> 
> Side note: The assert should also be changed to assertDOMProperty.

I saw this on OS X 32 bit.   Is this where you see it as well?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

On brasstacks it's happening on Windows and Linux too. Aaron, if you can reproduce it would be great if you could provide a patch. That failure blocks us from getting the tests into buildbot. If you can't please tell me and I will check the test on qa-horus itself.

Comment 4

[Aaron Train [:aaronmt]]

Am able to reproduce on OSX and Linux, have not tried Windows. 

Assuming the replace of getElement with getTab, the nav toolbar still opens instead. |var tabBar = tabBrowser.getTab(0);|

Comment 5

[Aaron Train [:aaronmt]]

The above works with tabs on bottom. I think it's just a targeting issue the position where we are clicking.

Comment 6

[Aaron Train [:aaronmt]]

This same regression is also hurting testCloseTab.js and testNewTab.js as both work with tabs on bottom.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Can you test with my patch from the events branch:
http://github.com/whimboo/mozmill/commits/events

I wonder if this will fix this problem.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It probably will because the rounded corners will not be the problem anymore. Remember those are at the top left for tabs on top. When we click at (2,2) we end up outside of the tab.

Comment 9

[Aaron Train [:aaronmt]]

Yep, your events branch fixes this issue when I change the element we want to click on to getTab at its index. As well, your events branch fixes the tabbedBrowsing tests.

I'll post a patch for this test in a minute.

Comment 10

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

This patch and test will pass once 1.5.1 is released with your events patch.

Comment 11

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

Default to the selectedIndex in getTab()

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 482624 [details] [diff] [review]
Patch v1 - (default)

Makes absolutely sense. Does this patch apply cleanly for older branches?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 482624 [details] [diff] [review]
Patch v1 - (default)

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/4fa3b29587d8

Comment 14

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (1.9.2 & 1.9.1)

1.9.2 and 1.9.1

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 482656 [details] [diff] [review]
Patch v1 - (1.9.2 & 1.9.1)

Landed backport:
http://hg.mozilla.org/qa/mozmill-tests/rev/b46cf069ad7d (mozilla1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/43b12508e3b8 (mozilla1.9.1)

I will leave this bug open until the dependencies have been fixed.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.