603717 - Change "Loading..." to "Connecting..." for initial state for tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dave Garrett]

(Alex Faaborg in bug 602964 comment #4)
> prior to getting the page title, when we are still waiting for DNS to resolve
> and the throbber is in state 1, can we set the tab text to "Connecting..." 
> This provides a clear textural description of what the first state of the
> throbber is, and we don't really have any other text to display there yet.

(Mike Beltzner in bug 602964 comment #5)
> I think that'd be a good change, yeah. I'd suggest we display the new URL in
> the location bar immediately (reverting if the page load is cancelled, natch)
> and put the "Connecting..." over to the right where the link preview went. This
> puts it, conveniently, right beside the "Stop" button.

(Alex Faaborg in bug 602964 comment #7)
> I think we currently say "Loading..." in background tabs that haven't resolved
> DNS yet.  This doesn't directly explain if we have received any information
> (does it mean loading in that Firefox is taking awhile to display it?), so we
> should probably change it to "Connecting..." for internal consistency.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Margaret: do we need a new string for this, or do we already have it?

Comment 2

[:Margaret Leibovic]

(In reply to comment #1)
> Margaret: do we need a new string for this, or do we already have it?

There's a "Connecting..." string in the sync locale files, but the right thing to do would be to add our own string to tabbrowser.properties (http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/tabbrowser.properties).

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I think we want to be able to get at the following strings, though for now only make use of the "Connecting" one. Should probably do this for b7 so that Axel isn't frowny-faces.

Strings to add to tabbrowser.properties:

Connecting…
Securing connection…
Searching…
Loading…
Waiting…
Downloading…

Localization note to include:

These will be used in the tab title or location bar to represent the various states as a web page loads.

Comment 4

[:Margaret Leibovic]

Attachment: strings

Comment 5

[Axel Hecht [:Pike]]

What's the difference between Loading and Downloading? And what's "Securing connection"?

Asking because I don't know, and that's likely a good indication that localizers may have the same question.

Comment 6

[Dave Garrett]

In some cases the throbber will switch from the connecting state to the loading state but the title isn't ready to be shown in the tab yet. In this instance, the "Connecting..." string should switchover to "Loading..." with the throbber switch until the title is available to show.

Comment 7

[Dave Garrett]

(In reply to comment #5)
> What's the difference between Loading and Downloading?

Downloading is getting the data (page, images, scripts, etc.) from the server.
Loading is reading the downloaded data to produce what the user sees.

Comment 8

[Dave Garrett]

(In reply to comment #3)
> Connecting…
> Securing connection…

"Securing connection" is just a part of "Connecting" in the instance of a secured connection. Does a status for this need to be shown separately and would it even be shown long enough to be useful?

There's also the old problem of using the word "secure" when generally it's meaning "encrypted", which is not necessarily the same thing.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 482645 [details] [diff] [review]
strings

r+ with the following nits:

LOCALIZATION NOTE: the following strings can be used in the tab title or location bar to represent various states as a web page loads:
 tabs.connecting = Firefox is sending a HTTP connection request
 tabs.securingConnection = Firefox is sending a HTTPS connection request
 tabs.searching = Firefox is searching for something (Awesomebar or Web search)
 tabs.loading = Firefox is loading the web page
 tabs.waiting = Firefox is waiting for a web resource to load
 tabs.downloading = Firefox is downloading a file for a helper application (PDF)

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Also note that this bug is about allowing us to use tabs.connecting instead of tabs.loading for the connection state. Future bugs will be filed about making use of the other states, and how to use them so that the location bar / tab title doesn't become "twitchy".

Comment 11

[Axel Hecht [:Pike]]

Firefox or brandShortName? Not that brandShortName is trivial in .properties.

Also, should tabs.securingConnection be tabs.encryptingConnection? Not user visible, but may help internally.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #11)
> Firefox or brandShortName? Not that brandShortName is trivial in .properties.

The strings are fine as Margaret's patch has them; I meant for that to all be one big ol' localization note so that your l10ners would have a better idea.

> Also, should tabs.securingConnection be tabs.encryptingConnection? Not user
> visible, but may help internally.

Sure.

Comment 13

[:Margaret Leibovic]

Attachment: patch

Addressed comments and switched code to use tabs.connecting instead of tabs.loading.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 482661 [details] [diff] [review]
patch

Please land on m-c default and relbranch, thanks!

Comment 15

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/26b5a5c0075e
http://hg.mozilla.org/mozilla-central/rev/caf14c06c00d