603764 - JS warning: variable basePath redeclares argument in chrome-harness.js:112

Status: NEW

(Testing :: Mochitest, defect)

Description

[David Dahl :ddahl]

I just started using head.js in my browser test suite and I always see this warning: 

JS Component Loader: WARNING chrome://mochikit/content/chrome-harness.js:112
                     variable basePath redeclares argument

Not sure if it is that big of a deal, I thought I would file this bug to find out.

Comment 1

[Marco Bonardo [:mak]]

browser-chrome test?

Comment 2

[Marco Bonardo [:mak]]

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/chrome-harness.js#112
112   var basePath = basePath.slice(0, idx);

basePath is passed in into the function, thus the warning

Comment 3

[Marco Bonardo [:mak]]

just to clarify, the local var is hiding the argument.

Comment 4

[David Dahl :ddahl]

ok, just wanted to see if this was a potential problem.

Comment 5

[Marco Bonardo [:mak]]

The code seems to do the right thing, so it's just matter of bad code throwing a correct warning.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Just need to remove the "var"