Status

RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: aki, Assigned: bear)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

We need to set the JARSIGNER env var to the right location.
However, relative paths will break since SUT uses JARSIGNER and Android packaging uses JARSIGNER.

Not sure how to fix this other than maybe a tools checkout in ~cltbld or /builds/slave/tools/ something.
(Reporter)

Updated

8 years ago
Assignee: nobody → bear
(Reporter)

Comment 1

8 years ago
1) I think previous to bug 567873 we were signing SUT with the debug key, but the fennec.apk with the nightly key.
2) We have never uploaded the SUT agent from an automated build.

That makes me wonder if we should remove SUT from the default build, or actually sign it properly and upload it.
(Reporter)

Comment 2

8 years ago
http://buildbot-master2.build.mozilla.org:8010/builders/Android%20R7%20mozilla-central%20nightly/builds/0

bash -c find build/mozilla-central/objdir/embedding/android -maxdepth 1 -type f -name fennec.apk

In the find_filepath step.  Shouldn't be looking in embedding/android, and it's no longer named fennec.apk.  We may not need the step at all.
Summary: Android nightly signing broken → Android nightlies broken
(Assignee)

Comment 3

8 years ago
Created attachment 482892 [details] [diff] [review]
add JARSIGNER environment var so "make package" can sign properly

quickest way to fix it was to add JARSIGNER environment to the "make package" and "make package-tests" calls so they can call mozpass.py for signing
Attachment #482892 - Flags: review?(aki)
(Reporter)

Comment 4

8 years ago
Comment on attachment 482892 [details] [diff] [review]
add JARSIGNER environment var so "make package" can sign properly

This should get nightly/depend build signing back to where it was before standard packaging landed; awesome.

Todo:

URGENT: fix nightly updates (on me)
When we have time: get SUT signed properly + uploaded?

I'll probably file a followup bug for the latter, as our list of blockers is pretty large.
Attachment #482892 - Flags: review?(aki) → review+
(Reporter)

Comment 5

8 years ago
Created attachment 482916 [details] [diff] [review]
[in staging] fix nightly updates

along with bear's patch. if this goes green + creates updates, will r? and land
(Reporter)

Comment 6

8 years ago
Created attachment 482967 [details] [diff] [review]
tested version.
Attachment #482916 - Attachment is obsolete: true
(Reporter)

Comment 7

8 years ago
Tested in two parts:

http://staging-master.build.mozilla.org:8012/builders/Android%20R7%20mozilla-central%20nightly/builds/5 died b/c of *.apk rather than fennec*.apk

http://staging-master.build.mozilla.org:8012/builders/Android%20R7%20mozilla-central%20nightly/builds/8 worked, but I commented out all the steps before updates and had to put in a fake got_revision.
(Reporter)

Updated

8 years ago
Attachment #482967 - Flags: review?(nrthomas)
Comment on attachment 482967 [details] [diff] [review]
tested version.

Looks fine, just need to make sure ftp has the file to pull for previous apk by changing the name there.
Attachment #482967 - Flags: review?(nrthomas) → review+
(Reporter)

Comment 9

8 years ago
Comment on attachment 482892 [details] [diff] [review]
add JARSIGNER environment var so "make package" can sign properly

http://hg.mozilla.org/build/buildbotcustom/rev/f2578f5f2cb5
Attachment #482892 - Flags: checked-in+
(Reporter)

Comment 11

8 years ago
reconfiged builder masters.
Nightly is respinning.
(Reporter)

Comment 12

8 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1287007702.1287013184.1150.gz&fulltext=1

We would be a little screwed in the nightly key department had last night's nightly worked, but it didn't, so the oct 12 nightly should update to this one.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.