Closed
Bug 603855
Opened 14 years ago
Closed 14 years ago
Support canceling a displayed notification
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(fennec2.0b2+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0b2+ | --- |
People
(Reporter: alexp, Assigned: alexp)
References
Details
Attachments
(1 file)
8.19 KB,
patch
|
mfinkle
:
review+
blassey
:
review+
pavlov
:
superreview+
|
Details | Diff | Splinter Review |
Sometimes the notification has to be canceled/hidden, for example when the download is deleted before its completion (see bug 603378).
The alert service needs to support this.
Assignee | ||
Comment 1•14 years ago
|
||
Add a new method to nsIAlertsProgressListener as discussed in bug 603378.
Mark, asking you to review the interface change.
Assignee | ||
Updated•14 years ago
|
Attachment #482758 -
Flags: review?(blassey.bugs)
Comment 2•14 years ago
|
||
Comment on attachment 482758 [details] [diff] [review]
Fix
Interface change looks OK to me. There is one thing you should do: change the GUID of nsIAlertsProgressListener.
It's something we do when ever we change an interface. In this case we haven't released software with nsIAlertsProgressListener (only in nightlies), but it's something I wanted you to know about and get used to doing. It lets people building binary components know that the interface changed.
Make sure you change it in all the required files.
Updated•14 years ago
|
Attachment #482758 -
Flags: review?(mark.finkle) → review+
Comment 3•14 years ago
|
||
Comment on attachment 482758 [details] [diff] [review]
Fix
changes an interface, needs sr
Attachment #482758 -
Flags: superreview?(pavlov)
Updated•14 years ago
|
Attachment #482758 -
Flags: review?(blassey.bugs) → review+
Updated•14 years ago
|
Attachment #482758 -
Flags: superreview?(pavlov) → superreview+
Updated•14 years ago
|
tracking-fennec: --- → 2.0b2+
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•