Closed Bug 603855 Opened 14 years ago Closed 14 years ago

Support canceling a displayed notification

Categories

(Core Graveyard :: Widget: Android, defect)

All
Android
defect
Not set
normal

Tracking

(fennec2.0b2+)

RESOLVED FIXED
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: alexp, Assigned: alexp)

References

Details

Attachments

(1 file)

Sometimes the notification has to be canceled/hidden, for example when the download is deleted before its completion (see bug 603378). The alert service needs to support this.
Attached patch FixSplinter Review
Add a new method to nsIAlertsProgressListener as discussed in bug 603378. Mark, asking you to review the interface change.
Assignee: nobody → alexp
Status: NEW → ASSIGNED
Attachment #482758 - Flags: review?(mark.finkle)
Attachment #482758 - Flags: review?(blassey.bugs)
Blocks: 603378
Comment on attachment 482758 [details] [diff] [review] Fix Interface change looks OK to me. There is one thing you should do: change the GUID of nsIAlertsProgressListener. It's something we do when ever we change an interface. In this case we haven't released software with nsIAlertsProgressListener (only in nightlies), but it's something I wanted you to know about and get used to doing. It lets people building binary components know that the interface changed. Make sure you change it in all the required files.
Attachment #482758 - Flags: review?(mark.finkle) → review+
Comment on attachment 482758 [details] [diff] [review] Fix changes an interface, needs sr
Attachment #482758 - Flags: superreview?(pavlov)
Attachment #482758 - Flags: review?(blassey.bugs) → review+
Attachment #482758 - Flags: superreview?(pavlov) → superreview+
Blocks: 605211
tracking-fennec: --- → 2.0b2+
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: