Closed
Bug 603919
Opened 15 years ago
Closed 15 years ago
nsHTMLInputElement.cpp: 'changed' event should be sent even if we can't store the last used directory (for <input type='file'>)
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
| Tracking | Status | |
|---|---|---|
| status2.0 | --- | ? |
People
(Reporter: mounir, Assigned: mounir)
References
()
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
|
2.27 KB,
patch
|
smaug
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
Currently, we have something like:
rv = StoreLastUsedDirectory()
NS_ENSURE_SUCCESS(rv, rv);
and after that, we send the 'changed' event.
We should ignore if StoreLastUsedDirectory is failing.
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [good first bug]
|
||
Updated•15 years ago
|
Assignee: nobody → bugspam.Callek
|
||
Updated•15 years ago
|
Blocks: 36619
Summary: changed event should be changed even if we can't store the last used directory (for <input type='file'>) → nsHTMLInputElement.cpp: 'changed' event should be sent even if we can't store the last used directory (for <input type='file'>)
|
|
Assignee | |
Comment 1•15 years ago
|
||
Justin, it would be great to have a test with the patch.
|
|
Assignee | |
Comment 2•15 years ago
|
||
Stealing this bug to Justin. I did not write tests given that they would have been quite long to write for a very small added value.
Assignee: bugspam.Callek → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #499536 -
Flags: review?(Olli.Pettay)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [good first bug] → [good first bug][needs-review]
|
||
Updated•15 years ago
|
Attachment #499536 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 499536 [details] [diff] [review]
Patch v1
Approval request: none risky patch which fixes edge cases situations (it actually brokes SeaMonkey test suite because of another bug).
Attachment #499536 -
Flags: approval2.0?
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [good first bug][needs-review] → [good first bug][needs-approval]
|
||
Updated•15 years ago
|
Attachment #499536 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][needs-approval] → [good first bug]
Target Milestone: --- → mozilla2.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•