nsHTMLInputElement.cpp: 'changed' event should be sent even if we can't store the last used directory (for <input type='file'>)

RESOLVED FIXED in mozilla2.0b10

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla2.0b10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status2.0 ?)

Details

(Whiteboard: [good first bug], )

Attachments

(1 attachment)

Currently, we have something like:
rv = StoreLastUsedDirectory()
NS_ENSURE_SUCCESS(rv, rv);
and after that, we send the 'changed' event.

We should ignore if StoreLastUsedDirectory is failing.
Whiteboard: [good first bug]
Assignee: nobody → bugspam.Callek
Blocks: 36619
status2.0: --- → ?
Summary: changed event should be changed even if we can't store the last used directory (for <input type='file'>) → nsHTMLInputElement.cpp: 'changed' event should be sent even if we can't store the last used directory (for <input type='file'>)
Justin, it would be great to have a test with the patch.
Posted patch Patch v1Splinter Review
Stealing this bug to Justin. I did not write tests given that they would have been quite long to write for a very small added value.
Assignee: bugspam.Callek → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #499536 - Flags: review?(Olli.Pettay)
Whiteboard: [good first bug] → [good first bug][needs-review]
Attachment #499536 - Flags: review?(Olli.Pettay) → review+
Comment on attachment 499536 [details] [diff] [review]
Patch v1

Approval request: none risky patch which fixes edge cases situations (it actually brokes SeaMonkey test suite because of another bug).
Attachment #499536 - Flags: approval2.0?
Whiteboard: [good first bug][needs-review] → [good first bug][needs-approval]
Attachment #499536 - Flags: approval2.0? → approval2.0+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/e5f203c18fbf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][needs-approval] → [good first bug]
Target Milestone: --- → mozilla2.0b10
You need to log in before you can comment on or make changes to this bug.