Closed
Bug 604056
Opened 15 years ago
Closed 15 years ago
nsIDocumentObserver methods should be declared with a macro
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
14.50 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
approval2.0+
|
Details | Diff | Splinter Review |
That would prevent looking for all declarations when a method signature changes.
Attachment #482869 -
Flags: review?(bzbarsky)
| Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Updated•15 years ago
|
Assignee: nobody → mounir.lamouri
Comment 1•15 years ago
|
||
Comment on attachment 482869 [details] [diff] [review]
Patch v1
>+++ b/content/base/public/nsIDocumentObserver.h
>+#define NS_DECL_NSIDOCUMENTOBSERVER_STYLESHEETREMOVED \
> virtual void StyleSheetRemoved(nsIDocument* aDocument, \
>- nsIStyleSheet* aStyleSheet, \
>- PRBool aDocumentSheet); \
>+ nsIStyleSheet* aStyleSheet, \
>+ PRBool aDocumentSheet);
Fix indent?
r=me with that
Attachment #482869 -
Flags: review?(bzbarsky) → review+
| Assignee | ||
Updated•15 years ago
|
Attachment #482869 -
Flags: approval2.0?
Updated•15 years ago
|
Attachment #482869 -
Flags: approval2.0? → approval2.0+
| Assignee | ||
Comment 2•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Updated•15 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•