Closed Bug 604056 Opened 9 years ago Closed 9 years ago

nsIDocumentObserver methods should be declared with a macro

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
That would prevent looking for all declarations when a method signature changes.
Attachment #482869 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Assignee: nobody → mounir.lamouri
Comment on attachment 482869 [details] [diff] [review]
Patch v1

>+++ b/content/base/public/nsIDocumentObserver.h
>+#define NS_DECL_NSIDOCUMENTOBSERVER_STYLESHEETREMOVED                        \
>     virtual void StyleSheetRemoved(nsIDocument* aDocument,                   \
>-                                   nsIStyleSheet* aStyleSheet,               \
>-                                   PRBool aDocumentSheet);                   \
>+                                 nsIStyleSheet* aStyleSheet,                 \
>+                                 PRBool aDocumentSheet);

Fix indent?

r=me with that
Attachment #482869 - Flags: review?(bzbarsky) → review+
Attachment #482869 - Flags: approval2.0?
Attachment #482869 - Flags: approval2.0? → approval2.0+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/1ee0a0890085
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.