Closed Bug 604076 Opened 14 years ago Closed 14 years ago

[ru] Changes in searchplugins for Firefox 3.6

Categories

(Mozilla Localizations :: ru / Russian, defect)

Product:
Mozilla Localizations
Component:
ru / Russian
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: unghost, Unassigned)

Details

(Keywords: productization, Whiteboard: [update l10n-src-verification])

Attachments

(1 file, 1 obsolete file)

Patch v.2
8.39 KB, patch
sethb
: review+
Details | Diff | Splinter Review
Attached patch Patch v.1 (obsolete) — — Splinter Review 
      No description provided.
Comment on attachment 482893 [details] [diff] [review]
Patch v.1

No need to add browser.search.order or change firefox-l10n.js.  Also, as I hinted at in earlier conversations, we typically don't make changes to the user interface for a stable branch.  Stas will need to confirm this one with me so we can figure out what is the best way within the policy to proceed.
Attachment #482893 - Flags: review-
Could you provide the current status of this conversation? There is 3.6.11 is out but searchplugins changes still not approved. According my experience this changes didn't affect current user settings but it's good feature for new users.
Summary:

1)  We do not need to add Ozon to browser.search.order
2)  There should be no changes to firefox-l10n.js
3)  We typically do not make changes to stable branches like 1.9.2 except in certain circumstances like a partner going out of business.
4)  If you want to swap Ozon into the Firefox 4 release, we will need to see the patch to do that in a bug that is not dealing with Firefox 3.6.

I have added Kev to this bug as he is also very interested in the status of the ru locale's search plugins.
Whiteboard: [update l10n-src-verification]
(In reply to comment #3)
> Summary:
> 
> 1)  We do not need to add Ozon to browser.search.order
> 2)  There should be no changes to firefox-l10n.js
OK, no problem.

> 3)  We typically do not make changes to stable branches like 1.9.2 except in
> certain circumstances like a partner going out of business.
But why? IT market in Russia growing and changing rapidly 

> 4)  If you want to swap Ozon into the Firefox 4 release, we will need to see
> the patch to do that in a bug that is not dealing with Firefox 3.6.
Sure. See #bz 604007 - Alexander added patch with appropriate changes.

> 
> I have added Kev to this bug as he is also very interested in the status of the
> ru locale's search plugins.
I wrote a letter to kev@ a week ago about this status. Hope he saw it ;)
Nothing in my inbox that mentions Ozon, specifically; this is the first we've heard of them being added (which is fine, just wondering what conversations you've had with the Ozon team). 

I'd be interested in understanding whether we have Ozon's permission to include, as well as whether there's been any conversations with them. Adding a commerce-oriented site is fine, but I'm wondering where the included plugin came from, and why we'd add them as an ordered entry behind Yandex and Google.

(In reply to comment #4)
> I wrote a letter to kev@ a week ago about this status. Hope he saw it ;)
I'd add to Kev's comments that I'd really like to see just a bit more research and concrete evidence that Ozon is a leading provider.  Alexa is one source we use regularly and Ozon is not listed in the top 40 sites there.

I understand that the Russian IT space is changing all the time.  I think this is all the more reason to research and make as informed decision as possible.  As mentioned in comment 3, we have guidelines to help us here.  We typically don't like to make changes to search plugins in the UI on a stable release.  It's a guideline and not a mandate.  If it's a compelling reason, we have approval from the provide, and we can see some evidence that this is best for users, we can consider the change.
(In reply to comment #4)
> > 4)  If you want to swap Ozon into the Firefox 4 release, we will need to see
> > the patch to do that in a bug that is not dealing with Firefox 3.6.
> Sure. See #bz 604007 - Alexander added patch with appropriate changes.

I "r-"ed that patch on 25-10-2010, adding some of the same reasons from comment 3.
Attached patch Patch v.2 — — Splinter Review 
1) browser.search.order.3 in region.properties is removed
2) Changes in firefox-l10n.js are removed
Attachment #482893 - Attachment is obsolete: true
Still waiting on info on Ozon and permission to use/include with Firefox. I have the email that is referenced in comment #4, but there's no info on Ozon in there. If you could let us know who the contact at Ozon is, and fwd copies of any emails with permission to Seth and I, that'd be great.

Thanks!
I received a letter dated November 9, 2010 from Ozon granting permission.  It was forwarded to me by Konstantin.  I'll forward to Kev for his records.
So, just to confirm, in this patch, you also now want to remove Rambler from 1.9.2?  It appears that you have already done this for L10n-central.  Is Rambler also no longer popular?  Can you give me one last piece that helps us document that change in this bug?  I would like all the decisions to be stated clearly here, if you don't mind, just so we have it all for review.  Thanks.
Just a note, the patch we finally approve in this bug needs to also remove Blogliens.
(In reply to comment #11)
> So, just to confirm, in this patch, you also now want to remove Rambler from
> 1.9.2?  It appears that you have already done this for L10n-central.  Is
> Rambler also no longer popular?  Can you give me one last piece that helps us
> document that change in this bug?  I would like all the decisions to be stated
> clearly here, if you don't mind, just so we have it all for review.  Thanks.

Rambler going out of search business - you can see it from the statistics -http://www.liveinternet.ru/i/s/19uCMK.png (http://www.liveinternet.ru/stat/ru/searches.html?period=month). alexa also confirm this movement - http://traffic.alexa.com/graph?&w=400&h=220&o=f&c=1&y=r&b=ffffff&n=666666&r=2y&u=rambler.ru&&u=yandex.ru&u=mail.ru&
Comment on attachment 487372 [details] [diff] [review]
Patch v.2

Please check this into the 1.9.2 branch.  Please add a checkin comment that references this change and bug 604076.  Thanks!
Attachment #487372 - Flags: review+
(In reply to comment #12)
> Just a note, the patch we finally approve in this bug needs to also remove
> Blogliens.
I've removed Bloglines in http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ru/rev/4df50b0e0e35
It's straightforward port of patch for l10n-central. I hope it's ok to push it without attaching separate patch.
Don't forget to sign off on these changes.  Thanks!
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: