604158 - nsGeolocation.cpp:762: warning: comparison between signed and unsigned integer expressions

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Daniel Holbert [:dholbert]]

../../../../mozilla/dom/src/geolocation/nsGeolocation.cpp: In member function ‘nsresult nsGeolocationService::StartDevice()’:
../../../../mozilla/dom/src/geolocation/nsGeolocation.cpp:762: warning: comparison between signed and unsigned integer expressions
../../../../mozilla/dom/src/geolocation/nsGeolocation.cpp: In member function ‘void nsGeolocationService::StopDevice()’:
../../../../mozilla/dom/src/geolocation/nsGeolocation.cpp:806: warning: comparison between signed and unsigned integer expressions

In both cases, the problem is that we're using an unsigned value to iterate through a nsCOMArray (whose Length() method returns a *signed* value).  So each comparison vs Length() is unsigned vs signed.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Fix: just use a PRInt32 instead of PRUint32.  (also fixes some whitespace on blank line in contextual code)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

Made one more whitespace tweak -- replacing
> i <mProviders.Count()
with
> i < mProviders.Count();
on the latter of the two fixed lines.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 482952 [details] [diff] [review]
fix

low risk, fixes warnings

Comment 4

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/26c6dfa66726