at-import-009 in CSS 2.1 test suite fails

RESOLVED FIXED in mozilla5

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {css2})

Trunk
mozilla5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
http://test.csswg.org/suites/css2.1/20100917/xhtml1/at-import-009.xht fails; there are actually two underlying bugs:
 (1) we're missing an UngetToken in error handling of parsing @charset rules
 (2) GatherMedia needs to stop at a block or semicolon in invalid cases

I have a patch for both in my patch queue, but I seem to recall that I wasn't quite happy with the patch for the second:

http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/6038c95fb322/at-charset-unget-token
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/6038c95fb322/gather-media-stop-in-at-rule
(Assignee)

Updated

7 years ago
Keywords: css2
(Assignee)

Comment 1

7 years ago
Created attachment 484548 [details] [diff] [review]
patch 1: missing UngetToken
Attachment #484548 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

7 years ago
Created attachment 484550 [details] [diff] [review]
patch 2: use more stop characters in GatherMedia

In theory, stop characters are a bad approach for everything except skipping over garbage.  I thought about removing other uses, but that makes error handling hard.  However, including extra stop chars isn't harmful in the other cases (other than skipping over garbage), since they're not valid syntax.
Attachment #484550 - Flags: review?(bzbarsky)
Comment on attachment 484548 [details] [diff] [review]
patch 1: missing UngetToken

r=me
Attachment #484548 - Flags: review?(bzbarsky) → review+
Comment on attachment 484550 [details] [diff] [review]
patch 2: use more stop characters in GatherMedia

r=me
Attachment #484550 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

7 years ago
Blocks: 605520
(Assignee)

Comment 5

7 years ago
https://hg.mozilla.org/projects/birch/rev/35b1ff9a626e
https://hg.mozilla.org/projects/birch/rev/60cef935a89c
Whiteboard: fixed-in-birch
(Assignee)

Comment 6

7 years ago
https://hg.mozilla.org/mozilla-central/rev/35b1ff9a626e
https://hg.mozilla.org/mozilla-central/rev/60cef935a89c
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.