Closed
Bug 604172
Opened 15 years ago
Closed 14 years ago
at-import-009 in CSS 2.1 test suite fails
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: dbaron, Assigned: dbaron)
References
(Blocks 1 open bug, )
Details
(Keywords: css2)
Attachments
(2 files)
730 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
7.16 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
http://test.csswg.org/suites/css2.1/20100917/xhtml1/at-import-009.xht fails; there are actually two underlying bugs:
(1) we're missing an UngetToken in error handling of parsing @charset rules
(2) GatherMedia needs to stop at a block or semicolon in invalid cases
I have a patch for both in my patch queue, but I seem to recall that I wasn't quite happy with the patch for the second:
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/6038c95fb322/at-charset-unget-token
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/6038c95fb322/gather-media-stop-in-at-rule
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #484548 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•15 years ago
|
||
In theory, stop characters are a bad approach for everything except skipping over garbage. I thought about removing other uses, but that makes error handling hard. However, including extra stop chars isn't harmful in the other cases (other than skipping over garbage), since they're not valid syntax.
Attachment #484550 -
Flags: review?(bzbarsky)
![]() |
||
Comment 3•15 years ago
|
||
Comment on attachment 484548 [details] [diff] [review]
patch 1: missing UngetToken
r=me
Attachment #484548 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 4•15 years ago
|
||
Comment on attachment 484550 [details] [diff] [review]
patch 2: use more stop characters in GatherMedia
r=me
Attachment #484550 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Updated•15 years ago
|
Blocks: css2.1-tests
Assignee | ||
Comment 5•14 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/35b1ff9a626e
https://hg.mozilla.org/projects/birch/rev/60cef935a89c
Whiteboard: fixed-in-birch
Assignee | ||
Comment 6•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/35b1ff9a626e
https://hg.mozilla.org/mozilla-central/rev/60cef935a89c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•