Closed Bug 604175 Opened 10 years ago Closed 10 years ago

ignoring of invalid at-keywords (@-keywords) should stop at end of containing block ({})

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: dbaron, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: css2)

Attachments

(1 file, 1 obsolete file)

http://test.csswg.org/suites/css2.1/20100917/xhtml1/at-rule-013.xht fails because we haven't implemented the new rule in CSS 2.1 regarding ignoring of invalid at-keywords:

# User agents must ignore an invalid at-keyword together with everything
# following it, up to the end of the block that contains the invalid at-keyword,
# or up to and including the next semicolon (;), or up to and including the next
# block ({...}), whichever comes first.

We incorrectly continue past the end of the block that contains the invalid at-keyword.
(citation)

The # quoted text above (User agents must ignore...) is from the list item that starts with "At-rules with unknown at-keywords." in section "4.2 Rules for handling parsing errors" in CSS 2.1: http://www.w3.org/Style/css2-updates/css2/syndata.html#parsing-errors
Attached patch patch (obsolete) — Splinter Review
Attachment #506827 - Flags: review?(bzbarsky)
Attached patch patchSplinter Review
oops, forgot to update patch description
Attachment #506827 - Attachment is obsolete: true
Attachment #506828 - Flags: review?(bzbarsky)
Attachment #506827 - Flags: review?(bzbarsky)
Comment on attachment 506828 [details] [diff] [review]
patch

r=me
Attachment #506828 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/b6a3ab183a8f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.