604181 - wrong mitchell in tree view

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[Robert Helmer [:rhelmer]]

I was just browsing the tree view and noticed that Dustin Mitchell's card is "on top" of Mitchell Baker's:

https://ldap.mozilla.org/phonebook/tree.php#search/[e-mail]

If you scroll down you can see Mitchell's card hiding under Dustin's.

Comment 5

[Trevor Norris [:tnorris]]

This seems to be an unforeseen problem with the built-in integrated search.

When you click on a name it fills the search form with that persons email address, then runs search. You can try searching in a similar manner with any email (e.g. [e-mail] will return all emails that end with "r"). This is why the two emails that also end with "mitchell" appear above hers.

To fix this bug a rewrite of how a users vCard are displayed will have to be performed (e.g. hardlink a user's account in the tree view on the left to their vCard).

Comment 8

[Brandon Savage [:brandon]]

Talked with Schalk, this is a complex javascript bug that he is better suited to handle. I'll work with him to make sure he has the background he needs.

Comment 9

[Fred Wenzel [:wenzel]]

I have a somewhat simple fix for this.

Comment 10

[Fred Wenzel [:wenzel]]

3-line fix is in r107908.

What this does:
- it lets multiple cards float next to each other rather than stacking them
- if there's more than one card, this patch disables making it sticky as you scroll down the tree. There will be edge cases where this is odd ("where's my card? Oh, at the top"), but deal with it. All people matching your query will then show up at the top of the page, next to each other.

Closing this one out. Rejoice!

CCing Rob Tucker and Jabba: Can either of you deploy this to prod?

Comment 11

[[e-mail]]

Thank you, Fred.
When will the fix be implemented so we can see the correct view?
Thanks again.

Comment 12

[Rob Tucker [:rtucker]]

I'm pushing to production now. Should be visible in a few minutes.

Comment 13

[[e-mail]]

Awesome. 
Thanks!