604229 - current "potential resubmit" check prevents post_timestamp update

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Robert Helmer [:rhelmer]]

In bug 602201 comment 5 I mentioned getting an exception when testing Socorro 1.8 against HBase 0.89. I thought that this was just a problem with my local setup but after reading the code and doing a little more testing I'm not so sure.

Here hbaseClient.py looks to see if (now - 'processor_state:post_timestamp') > resubmitTimeDeltaThreshold, and if so then log "avoiding potential resubmit" and continue:

http://code.google.com/p/socorro/source/browse/trunk/socorro/storage/hbaseClient.py#672

From my testing, row['processor_state:post_timestamp'] will always throw a KeyError and this will be handled and processing goes on:

http://code.google.com/p/socorro/source/browse/trunk/socorro/storage/hbaseClient.py#680

However, that means "now" does not get assigned:
http://code.google.com/p/socorro/source/browse/trunk/socorro/storage/hbaseClient.py#674

And an exception will be raised here, with a log message of "something has gone wrong in the submission for (...)":

http://code.google.com/p/socorro/source/browse/trunk/socorro/storage/hbaseClient.py#724

The crash will be processed, but processor_state:post_timestamp will not be updated.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: move "now" assignment out of try block

Comment 2

[K Lars Lohn [:lars] [:klohn]]

Comment on attachment 483016 [details] [diff] [review]
move "now" assignment out of try block

this is the correct solution.

Comment 3

[Robert Helmer [:rhelmer]]

Committed revision 2593.

Thanks Lars!