Closed Bug 604238 Opened 10 years ago Closed 10 years ago

Fix iframe Console API/Observer logging

Categories

(DevTools :: General, defect)

x86
All
defect
Not set
normal

Tracking

(blocking2.0 betaN+)

RESOLVED WORKSFORME
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: ddahl, Assigned: ddahl)

Details

Our iFrame testing has revealed that the lazy console integration patch has broken iframe network and console API logging.

I am breaking this out here into its own bug to isolate this work. We should also look at and implement tests for normal <frames> as well.

The checks that were disabled were in: toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_593003_iframe_wrong_hud.js
Summary: iframe Console API/Observer logging → Fix iframe Console API/Observer logging
Nominating this as a blocker. We need both the lazy console (which is already a blocker) and iframe support.
Assignee: nobody → ddahl
blocking2.0: --- → ?
I'm not sure I understand - is this bug covering an issue introduced by the unlanded patches for bug 568629/bug 587734? If so, why can't we fix it before they land?
blocking2.0: ? → betaN+
(In reply to comment #2)
> I'm not sure I understand - is this bug covering an issue introduced by the
> unlanded patches for bug 568629/bug 587734? If so, why can't we fix it before
> they land?

We could fix it before they land, but between compartments and other things going on, I just want to get the lazy console landed and not delay it any more.
I think this is no longer relevant now, right? AFAIK the bugs in comment 2 didn't break this.
blocking2.0: betaN+ → beta9+
(In reply to comment #4)
> I think this is no longer relevant now, right? AFAIK the bugs in comment 2
> didn't break this.

correct. all of the iframe tests are activated and passing
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Note: this was fixed by the split up tests bug 581069
As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)
blocking2.0: beta9+ → betaN+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.