604238 - Fix iframe Console API/Observer logging

Status: RESOLVED WORKSFORME

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

Our iFrame testing has revealed that the lazy console integration patch has broken iframe network and console API logging.

I am breaking this out here into its own bug to isolate this work. We should also look at and implement tests for normal <frames> as well.

The checks that were disabled were in: toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_593003_iframe_wrong_hud.js

Comment 1

[Kevin Dangoor]

Nominating this as a blocker. We need both the lazy console (which is already a blocker) and iframe support.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I'm not sure I understand - is this bug covering an issue introduced by the unlanded patches for bug 568629/bug 587734? If so, why can't we fix it before they land?

Comment 3

[David Dahl :ddahl]

(In reply to comment #2)
> I'm not sure I understand - is this bug covering an issue introduced by the
> unlanded patches for bug 568629/bug 587734? If so, why can't we fix it before
> they land?

We could fix it before they land, but between compartments and other things going on, I just want to get the lazy console landed and not delay it any more.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I think this is no longer relevant now, right? AFAIK the bugs in comment 2 didn't break this.

Comment 5

[David Dahl :ddahl]

(In reply to comment #4)
> I think this is no longer relevant now, right? AFAIK the bugs in comment 2
> didn't break this.

correct. all of the iframe tests are activated and passing

Comment 6

[David Dahl :ddahl]

Note: this was fixed by the split up tests bug 581069

Comment 7

[LegNeato]

As per today's meeting, beta 9 will be a time-based release. Marking these all betaN+. Please move it back to beta9+ if  you believe it MUST be in the next beta (ie: trunk is in an unshippable state without this)