unicode-bidi: bidi-override doesn't work on table cells

RESOLVED FIXED

Status

()

Core
Layout: Tables
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {css2})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
http://test.csswg.org/suites/css2.1/20101001/xhtml1/bidi-override-002.xht shows that unicode-bidi: bidi-override doesn't work on table cells.

I think all we need to do to fix this is give the anonymous block that lives inside table cells unicode-bidi: inherit.
(Assignee)

Comment 1

7 years ago
Work in progress, although these rules could use a little cleanup:
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/07626d34460e/unicode-bidi-inherit

Comment 2

7 years ago
Do we need similar changes to ::-moz-fieldset-content?
(Assignee)

Comment 3

7 years ago
Also:
http://test.csswg.org/suites/css2.1/20101001/html4/unicode-bidi-applies-to-007.htm
http://test.csswg.org/suites/css2.1/20101001/xhtml1/unicode-bidi-applies-to-007.xht
(Assignee)

Updated

7 years ago
Blocks: 605520
(Assignee)

Comment 4

6 years ago
Created attachment 527729 [details] [diff] [review]
patch

As far as I can tell, adding to :-moz-anonymous-block and :-moz-anonymous-positioned-block shouldn't make any difference since they always contain other blocks, but it seems like a good idea to add it anyway in case we use those pseudos for other things.
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #527729 - Flags: review?(bzbarsky)

Comment 5

6 years ago
Comment on attachment 527729 [details] [diff] [review]
patch

r=me
Attachment #527729 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/b3d5c9a7a5e5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.