Bug 514570 causes bustage Win64 debug build

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
x86_64
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
jsdebug.c is C lang file, so bustage occurs by JS_ASSERT

c:/mozilla-build/python/python2.6.exe -O c:/Workspace/hg.mozilla.org/mozilla-win64/build/cl.py cl -Fojsdebug.obj -c  -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DOSTYPE=\"WINNT6.0\" -DOSARCH=WINNT -DEXPORT_JSD_API  -I/c/Workspace/hg.mozilla.org/mozilla-win64/js/jsd -I. -I../../dist/include -I../../dist/include/nsprpub  -Ic:/Workspace/hg.mozilla.org/objdir-win64-dbg/dist/include/nspr -Ic:/Workspace/hg.mozilla.org/objdir-win64-dbg/dist/include/nss         -TC -nologo -W3 -Gy -Fdgenerated.pdb  -DDEBUG -D_DEBUG -DTRACING -Zi -O1 -MDd           -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT /c/Workspace/hg.mozilla.org/mozilla-win64/js/jsd/jsdebug.c
jsdebug.c
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(599) : error C2143: syntax error : missing ';' before 'type'
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(600) : error C2275: 'uint64' : illegal use of this type as an expression
        c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsotypes.h(77) : see declaration of 'uint64'
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(600) : error C2146: syntax error : missing ';' before identifier 'strBits'
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(600) : error C2065: 'strBits' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(600) : warning C4244: '=' : conversion from 'uint64' to 'int', possible loss of data
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(601) : error C2065: 'strBits' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(601) : warning C4293: '>>' : shift count negative or too big, undefined behavior
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(602) : error C2065: 'l' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(602) : error C2224: left of '.asBits' must have struct/union type
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(602) : error C2065: 'strBits' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(603) : error C2065: 'l' : undeclared identifier
c:\workspace\hg.mozilla.org\objdir-win64-dbg\dist\include\jsval.h(603) : error C2440: 'return' : cannot convert from 'int' to 'jsval_layout'
make[1]: *** [jsdebug.obj] Error 2
(Assignee)

Comment 1

8 years ago
Created attachment 483122 [details] [diff] [review]
fix
Attachment #483122 - Flags: review?(jimb)
(Assignee)

Updated

8 years ago
Blocks: 471090
Comment on attachment 483122 [details] [diff] [review]
fix

Stealing, this is small fry not worth delaying in pursuit of politeness -- land away.
Attachment #483122 - Flags: review?(jimb) → review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/tracemonkey/rev/892f7bd89e2d
Whiteboard: fixed-in-tracemonkey

Comment 5

8 years ago
Why wasn't this uncovered by the try server and tm tinderbox?  See, for example, the green builds for 626b9756fd66.
(Assignee)

Comment 6

8 years ago
(In reply to comment #5)
> Why wasn't this uncovered by the try server and tm tinderbox?  See, for
> example, the green builds for 626b9756fd66.

No try server for Win64.

And, although Win64 tinderbox for TM is from this month, this is nightly only since Win64 it Tier2.  So, It doesn't run build and all tests per landed.

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/892f7bd89e2d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
No longer blocks: 471090

Updated

8 years ago
Blocks: 558448

Updated

8 years ago
Blocks: 471090
No longer blocks: 558448
You need to log in before you can comment on or make changes to this bug.