604353 - Random failure into browser_viewport.js

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Bug 601619 change the awesome panel code and this add an effect on browser_viewport.js.
browser_viewport.js also behave differently while run alone or in the testsuite, those needs to be fixed.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Most of the patch is just code rewrite :
 * loadUrl -> loadURL
 * var -> let
 * adding spaces around "+" when needed
 * renaming working_tab -> currentTab to fit with the name used in most of the test

The interesting part are:
 * the change in browser.xml (not needed) but I'm not sure we need to send all thoses messages when there is no change in the scale level

 * the move from setTimeout(callback, 0) to waitFor. In most situation we are fine and we don't really wait for anything since there is a check at the beginning of the function to ensure the condition is not already ok. But for the cases where 2 MozScrolledAreaChanged happened this allow us to wait for the right scale and prevent those random orange

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/8f8a097333ed

Comment 3

[Anna (Waverley)]

Vivien can you provide some steps to reproduce ? So that I can verify this bug...

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

it is verified, there are issues with browser_viewport.js but they are different.

Comment 5

[Anna (Waverley)]

VERIFIED FIXED on:

Build ID: Mozilla/5.0 (Maemo; Linux armv7l; rv:6.0a1) Gecko/20110510
Firefox/6.0a1 Fennec/6.0a1

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110515 Firefox/6.0a1 Fennec/6.0a1 


Mozilla /5.0 (Android;Linux armv7l;rv:5.0a1) Gecko/20110515 Firefox/5.0a2 Fennec/5.0a2 

Devices: Nokia N900(Maemo GTK), HTC Desire Z (Android 2.2)