604431 - Command Completion broken on today's build in JSTerm

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Web Console's JSTerm is no longer completing entries.

today's build: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre)
Gecko/20101014 Firefox/4.0b8pre
built from:
http://hg.mozilla.org/mozilla-central/rev/ad0a0be8be74

Comment 1

[Rob Campbell [:rc] (:robcee)]

requesting blocking

Comment 2

[David Dahl :ddahl]

I'm seeing this:

Error: uncaught exception: [Exception... "Component is not available"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: resource:///modules/HUDService.jsm :: JSPropertyProvider :: line 3878"  data: no]

Error: obj.__lookupGetter__ is not a function
Source File: resource:///modules/HUDService.jsm
Line: 3861

Comment 3

[David Dahl :ddahl]

We did not know this happend via our tests due to this changeset:

http://hg.mozilla.org/mozilla-central/rev/29c228a4d7eb

Comment 4

[Rob Campbell [:rc] (:robcee)]

was there a bug added to re-enable them anywhere? Johnny, help us out here.

Comment 5

[Kevin Dangoor]

ddahl has a fix to this which he has said is a "one-liner". The fix is apparently visible in another patch:

https://bugzilla.mozilla.org/show_bug.cgi?id=587734#c60

but ddahl will break that out to land it for beta 7.

Comment 6

[David Dahl :ddahl]

I am attaching a patch momentarily

Comment 7

[David Dahl :ddahl]

Attachment: v 0.1 Fix tab-completion

one liner that fixes tab completion

Comment 8

[Rob Campbell [:rc] (:robcee)]

this fix clears the errors from the disabled tests in bug 604536. Feedback+++++ from me.

Comment 9

[David Dahl :ddahl]

http://hg.mozilla.org/mozilla-central/rev/a191d97b0192

Comment 10

[David Dahl :ddahl]

landed on BRANCH:

http://hg.mozilla.org/mozilla-central/rev/82255b586ada