Doorhanger text hidden when lwthemes (personas) are installed

VERIFIED FIXED

Status

()

Toolkit
Themes
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: mao, Assigned: Margaret)

Tracking

Trunk
All
Windows XP
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

(Whiteboard: [doorhanger])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
On a clean profile, install any Persona, e.g. https://addons.mozilla.org/en-US/firefox/addon/49331

Then open http://flashgot.net/getit and click on the "direct download for FlashGot" link.

The doorhanger notification for the XPI installation will have no text.

Reproducible: always
(Reporter)

Updated

7 years ago
blocking2.0: --- → ?

Updated

7 years ago
Blocks: 554937
Unable to reproduce this on OSX, what platform are you testing?
Component: Themes → Add-ons Manager
QA Contact: themes → add-ons.manager
(Reporter)

Comment 2

7 years ago
Per platform flags (XP/All), I've reproduced it on XP 64, Mozilla/5.0 (Windows NT 5.2; WOW64; rv:2.0b8pre) Gecko/20101014 Firefox/4.0b8pre ID:20101014041748, while my original reporter http://forums.informaction.com/viewtopic.php?p=22662#p22662 was likely on XP 32, Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101014 Firefox/4.0b8pre.
Ah yes, windows only, the text is turning white for some reason, presumably some of the colours from the persona are bleeding into the doorhanger
blocking2.0: ? → final+
Component: Add-ons Manager → Theme
Product: Toolkit → Firefox
QA Contact: add-ons.manager → theme
Need the proper :-moz-lwtheme-brighttext/:-moz-lwtheme-darktext styles here (probably applies to all platforms).
(Assignee)

Comment 5

7 years ago
Created attachment 483348 [details] [diff] [review]
patch

It ended up being a toolkit fix ;)
Assignee: nobody → margaret.leibovic
Attachment #483348 - Flags: review?(dtownsend)
(Assignee)

Updated

7 years ago
Attachment #483348 - Attachment is patch: true
Attachment #483348 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

7 years ago
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Whiteboard: [needs review dtownsend]
Attachment #483348 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

7 years ago
Whiteboard: [needs review dtownsend] → [can land]
(Assignee)

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/567d2e1f8f68
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [can land]
Whiteboard: [doorhanger]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.