604532 - Copying from location bar copies the old URL (?)

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Jesse Ruderman]

Using: Firefox trunk on Mac, local build

Steps to reproduce:
1. Cmd+L
2. Right
3. Type "xxx"
4. Cmd+A
5. Cmd+X

Result: the "xxx" part of the URL is not moved to the clipboard.

I've been hitting this bug frequently, with slightly different steps, while trying to copy URLs from Firefox into IRC.

I don't know if this is a Location Bar bug or an Editor bug.

Comment 1

[(no longer active)]

I'm pretty sure that this is the editor...

Comment 2

[(no longer active)]

Meant to set the status to ASSIGNED...

Comment 3

[(no longer active)]

The location bar has its own controller for copy and cut operations.  Here is the code responsible for grabbing the selected part of the text from the location bar:

<http://mxr.mozilla.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#425>

What's incorrect here is the value returned by selectionEnd.  The reason that this happens is that appending the text as done in comment 0 causes us to create a new textframe, and selectionEnd fails to handle that correctly.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 483527 [details] [diff] [review]
Patch (v1)

Don't we need to fix urlBindings.xml as well? It shouldn't be depending on this.

Comment 6

[(no longer active)]

(In reply to comment #5)
> Comment on attachment 483527 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=483527
> Patch (v1)
> 
> Don't we need to fix urlBindings.xml as well? It shouldn't be depending on
> this.

I don't think there's anything wrong with urlbarBindings.xml.  It's realying on selectionStart and selectionEnd, which are APIs that we expose to content.  I don't see what's wrong with depending on those APIs.

Comment 7

[(no longer active)]

roc: see comment 6 please.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK, I see.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ec9b314fdb5f