604584 - Need some guidance for new reviewers

Status: RESOLVED FIXED

(Camino Graveyard :: Product Site, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Placeholder to let me generate r/f requests

This came up when Ilya did his first review last week; we have a bunch of documentation on building, coding, committing, and the review process from the perspective of a patch author, but nothing to help people when they make the jump from patch author to reviewer.

I stubbed out a section at the bottom of the Reviewing page with info on this, both on the mechanics of a Bugzilla review and on review content: http://wiki.caminobrowser.org/Development:Reviewing#Helpful_Tips_for_New_Reviewers

Mechanics is pretty well filled in, so I'd mostly like suggestions there.

Review content is pretty empty, since that's something I don't do, codewise.  I'd like some Camino developers to volunteer to flesh that section out a little bit more.

Feel free to edit the page directly (particularly the "review content" aka "What to Look For" section), or leave smaller comments here if you'd like.

Comment 1

[Chris Lawson (gone)]

Comment on attachment 483394 [details]
Placeholder to let me generate r/f requests

This looks pretty good so far to me. If I think of anything specific to put in the "What to look for" section, I'll pop over there and do it.

I'll ping froodian and see if he can take a quick look at this, too, and hendy might also have some useful contributions, so requesting addl. feedback? from him.

Comment 2

[Stuart Morgan]

Comment on attachment 483394 [details]
Placeholder to let me generate r/f requests

Looks great!

I can't think of anything specific to add to the 'what to watch for' section; "Good coding" is not particularly useful ;) I suspect we'll have to just grow that section over time with any particularly common issues.

Comment 3

[Ilya Sherman]

Comment on attachment 483394 [details]
Placeholder to let me generate r/f requests

Yeah, looks very good -- thanks! =)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm going to call this FIXED, to get it out of my queue (and out of the r/f queue), since several people have looked over the page and approved.

If hendy or froodian have further comments, they can of course make them (here, or as edits), and if we have other things to add at some point, we can add them directly or file new bugs on them.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 483394 [details]
Placeholder to let me generate r/f requests

(Per comment 4)