604673 - <output> should be subject for constraint validation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

We are currently following the specifications but that seems to be wrong. It would be nice to have .setCustomValidity() working with <output>.

Comment 1

[Mounir Lamouri (:mounir)]

W3C bug: http://www.w3.org/Bugs/Public/show_bug.cgi?id=10912

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

What is the status of the spec change?

Comment 4

[Mounir Lamouri (:mounir)]

The bug still got no answer but I think we should ship with this change and see, this way, if there is a real need. FWIW, Jonas was supporting this plan.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 484085 [details] [diff] [review]
Patch v1


>-:invalid {
>+:not(output):invalid {
>   box-shadow: 0 0 1.5px 1px red;
> }
> 
>+output:invalid {
>+  color: red;
>+}
>+

I think this change should get ui-review.

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 484085 [details] [diff] [review]
Patch v1

If this works the way I think it does, it should be fine. I'm a bit hazy on the use of the HTML5 <output> element, and would love to see a demo of how this would be done in a real-life situation, though.

Don't let that stop this from shipping in a beta for wider feedback, though. :)

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/2eb1331a2bc4

Comment 8

[Janet Swisher]

I've documented this, and marked it as non-standard (https://developer.mozilla.org/en/DOM/HTMLOutputElement). If/when the spec is changed, we'll need to remove the non-standard label.