Closed Bug 604673 Opened 9 years ago Closed 9 years ago

<output> should be subject for constraint validation

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: dev-doc-complete, html5, Whiteboard: [good first bug])

Attachments

(1 file)

We are currently following the specifications but that seems to be wrong. It would be nice to have .setCustomValidity() working with <output>.
Keywords: dev-doc-needed
Whiteboard: [good first bug]
Summary: <output> should not be barred from constraint validation → <output> should be subject for constraint validation
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
Attachment #484085 - Flags: review?(Olli.Pettay)
What is the status of the spec change?
The bug still got no answer but I think we should ship with this change and see, this way, if there is a real need. FWIW, Jonas was supporting this plan.
Comment on attachment 484085 [details] [diff] [review]
Patch v1


>-:invalid {
>+:not(output):invalid {
>   box-shadow: 0 0 1.5px 1px red;
> }
> 
>+output:invalid {
>+  color: red;
>+}
>+

I think this change should get ui-review.
Attachment #484085 - Flags: review?(Olli.Pettay) → review+
Attachment #484085 - Flags: ui-review?(limi)
Attachment #484085 - Flags: approval2.0?
Attachment #484085 - Flags: approval2.0? → approval2.0+
Comment on attachment 484085 [details] [diff] [review]
Patch v1

If this works the way I think it does, it should be fine. I'm a bit hazy on the use of the HTML5 <output> element, and would love to see a demo of how this would be done in a real-life situation, though.

Don't let that stop this from shipping in a beta for wider feedback, though. :)
Attachment #484085 - Flags: ui-review?(limi) → ui-review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/2eb1331a2bc4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Depends on: 613113
I've documented this, and marked it as non-standard (https://developer.mozilla.org/en/DOM/HTMLOutputElement). If/when the spec is changed, we'll need to remove the non-standard label.
You need to log in before you can comment on or make changes to this bug.