Closed Bug 604871 Opened 10 years ago Closed 10 years ago

Add --enable-profiling configure option in comm-central (port Bug 592923)

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: Nomis101, Assigned: Nomis101)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch port Bug 592923 to c-c (obsolete) — Splinter Review
Because we also use -fomit-frame-pointer in comm-central, I think its a good idea to port Bug 592923. As you can read in this bug "perf and shark both like having frame pointers. But we don't like frame pointers because they make our code slow."

This patch is a port from the checked-in m-c patch: http://hg.mozilla.org/mozilla-central/rev/c60ae9b15dd2
Attachment #483715 - Flags: review?(bugspam.Callek)
You probably need to AC_SUBST the variable, per Khuey's fix:

http://hg.mozilla.org/mozilla-central/rev/511c41f90373
OH, thanks. I haven't recognized this bustage fix.
Attachment #483715 - Attachment is obsolete: true
Attachment #483746 - Flags: review?(bugspam.Callek)
Attachment #483715 - Flags: review?(bugspam.Callek)
Attachment #483746 - Flags: review?(bugspam.Callek) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/e44305612904
Assignee: nobody → Nomis101
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
You need to log in before you can comment on or make changes to this bug.