Remove -OPT:NOWIN98 from the tree

RESOLVED FIXED in mozilla2.0b8

Status

RESOLVED FIXED
8 years ago
9 months ago

People

(Reporter: khuey, Assigned: RyanVM)

Tracking

unspecified
mozilla2.0b8
x86
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug], URL)

Attachments

(1 attachment)

In MSVC 2010, -OPT:NOWIN98 is completely gone and causes a syntax error if used.  It needs to be removed from the tree.
Component: Canvas: 2D → Build Config
QA Contact: canvas.2d → build-config
(Assignee)

Comment 1

8 years ago
I'm assuming we're not worrying about the third-party code (NSIS, 7zip) using it?
Thought I filed this a while ago, maybe not. Maybe I just mentioned it in some other bug?
(Assignee)

Comment 3

8 years ago
Kyle, can I get an answer on comment #1? I'm going to make this patch and want to make sure I'm getting everything covered by this bug.
(Assignee)

Comment 4

8 years ago
Created attachment 488032 [details] [diff] [review]
Remove last vestiges of OPT:NOWIN98 from Mozilla code

Per comment #1, I only killed it from the Mozilla code. Let me know if you want it gone from the third party code as well.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #488032 - Flags: review?(khuey)
Comment on attachment 488032 [details] [diff] [review]
Remove last vestiges of OPT:NOWIN98 from Mozilla code

Idk why we support trace-malloc in opt builds, but this patch is nice regardless.

r=me
Attachment #488032 - Flags: review?(khuey) → review+
(Assignee)

Updated

8 years ago
Attachment #488032 - Flags: approval2.0?
Comment on attachment 488032 [details] [diff] [review]
Remove last vestiges of OPT:NOWIN98 from Mozilla code

trace-malloc in an opt build is almost as NPOT(default)B as it gets.  I'd just land this.
Attachment #488032 - Flags: approval2.0?
(Assignee)

Comment 8

8 years ago
Go for it, in that case.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/0e60e90039ca
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.