604937 - Remove -OPT:NOWIN98 from the tree

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

In MSVC 2010, -OPT:NOWIN98 is completely gone and causes a syntax error if used.  It needs to be removed from the tree.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I'm assuming we're not worrying about the third-party code (NSIS, 7zip) using it?

Comment 2

[(not currently active) Ted Mielczarek]

Thought I filed this a while ago, maybe not. Maybe I just mentioned it in some other bug?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Kyle, can I get an answer on comment #1? I'm going to make this patch and want to make sure I'm getting everything covered by this bug.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Remove last vestiges of OPT:NOWIN98 from Mozilla code

Per comment #1, I only killed it from the Mozilla code. Let me know if you want it gone from the third party code as well.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment 1 is correct.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 488032 [details] [diff] [review]
Remove last vestiges of OPT:NOWIN98 from Mozilla code

Idk why we support trace-malloc in opt builds, but this patch is nice regardless.

r=me

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 488032 [details] [diff] [review]
Remove last vestiges of OPT:NOWIN98 from Mozilla code

trace-malloc in an opt build is almost as NPOT(default)B as it gets.  I'd just land this.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Go for it, in that case.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0e60e90039ca