604957 - Change Sandbox constructor

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Peter Van der Beken [:peterv]]

We decided to change the API slightly. Currently it has two optional arguments but they're really independent, so one always has to specify the first if the second needs to be set. We should change that to be one optional argument that's an object with properties instead.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1.1

Comment 3

[Benjamin Smedberg]

If we have to do this, it has to block beta7, as an API change.

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1.2

Comment 5

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/tracemonkey/rev/cfb808ab6aa0

Comment 6

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/f68f9d741b29

Comment 7

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en/Components.utils.evalInSandbox
https://developer.mozilla.org/en/Components.utils.Sandbox

The latter article in particular got a major overhaul, and I would appreciate it if someone would review it. In particular, I don't know what the wantXrays parameter means exactly, so if someone can clarify that it would be lovely.