605068 - Adding and deleting bookmarks via AppleScript need to trigger Spotlight metadata changes

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

With Stuart's patch in bug 569258, adding and deleting bookmarks via AppleScript don't trigger the creation of new Spotlight metadata nor the deletion of that metadata.

Amazingly, this did actually work before the patch, so we should fix the regression.

Simple test script:

tell application "Camino"
    make new bookmark with properties ¬
        {name:"Example", URL:"http://www.example.com/"} at end of ¬
        bookmarks of bookmark bar collection
    --comment out lines above and uncomment line below to test deletion
    --delete bookmark "Example" of bookmark bar collection
end tell

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to bug 569258 comment #9)
> Oh, right. Maybe a follow-up bug for that? I'm willing to regress AS to fix the
> common cases (I'll fix at least removal quickly though; adding I'll need to
> play with to see if I can tell the difference between moving and creating).

The UUID shouldn't change in the move case, right?  (If it does, I'd consider that to be a bug; if we ever get syncing working, that would be a pain for those users.)

Or is the issue/hard part of move that we won't necessarily know to pay attention to the UUID (or anything else) before the move happens?

Comment 2

[Stuart Morgan]

Actually it looks like move would have to be a delete+insert, so this should be easy both ways.

Comment 3

[Stuart Morgan]

Attachment: fix

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> The UUID shouldn't change in the move case, right?  (If it does, I'd consider
> that to be a bug; if we ever get syncing working, that would be a pain for
> those users.)

I tested, and 'move' does indeed preserve the UUID.  Yay AppleScript for doing the right thing :)

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 488686 [details] [diff] [review]
fix

sr=pink

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the CAMINO_2_0_BRANCH in advance of 2.0.6; leaving open for Cm2.1 landing.

Comment 7

[Stuart Morgan]

Landed http://hg.mozilla.org/camino/rev/4d1e45034de6