Closed Bug 605079 Opened 9 years ago Closed 9 years ago

Search engines are not added in the list via nsISidebar

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: andreea.pod, Assigned: azakai)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101014 Firefox/4.0b8pre
Build Identifier: 20101017

the selected search plugins are not installed.

Reproducible: Always

Steps to Reproduce:
1.Go to http://mycroft.mozdev.org/search-engines.html
2.Select and add two or more search plugins (such as Ebay auctions).

Actual Results:  
no feedback from the installation and the search plugins don't appear in the search options list.

Expected Results:  
the new search plugins should be installed
OS: Other → Android
Hardware: Other → ARM
Summary: search engine not added in the list → Search engines are not added in the list
Status: UNCONFIRMED → NEW
Ever confirmed: true
Vivien - can you take a look? We must have regressed something
tracking-fennec: --- → 2.0b2+
Vivien says this is a nsISidebar problem. Likely, an e10s problem related to the sidebar JS object.
tracking-fennec: 2.0b2+ → 2.0+
OS: Android → All
Summary: Search engines are not added in the list → Search engines are not added in the list via nsISidebar
Assignee: nobody → azakai
Hardware: ARM → All
Attached patch patchSplinter Review
Remote the AddSearchProvider call.
Attachment #491015 - Flags: review?(mark.finkle)
Comment on attachment 491015 [details] [diff] [review]
patch

Looks good. Did you test on a live site?
Attachment #491015 - Flags: review?(mark.finkle) → review+
Yes, I tested on the website mentioned in comment 0, http://mycroft.mozdev.org/search-engines.html
pushed:
http://hg.mozilla.org/mobile-browser/rev/73b696d6aa02
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Similar to test case:

https://litmus.mozilla.org/show_test.cgi?id=15031
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.