605079 - Search engines are not added in the list via nsISidebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101014 Firefox/4.0b8pre
Build Identifier: 20101017

the selected search plugins are not installed.

Reproducible: Always

Steps to Reproduce:
1.Go to http://mycroft.mozdev.org/search-engines.html
2.Select and add two or more search plugins (such as Ebay auctions).

Actual Results:  
no feedback from the installation and the search plugins don't appear in the search options list.

Expected Results:  
the new search plugins should be installed

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien - can you take a look? We must have regressed something

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien says this is a nsISidebar problem. Likely, an e10s problem related to the sidebar JS object.

Comment 3

[Alon Zakai (:azakai)]

Attachment: patch

Remote the AddSearchProvider call.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 491015 [details] [diff] [review]
patch

Looks good. Did you test on a live site?

Comment 5

[Alon Zakai (:azakai)]

Yes, I tested on the website mentioned in comment 0, http://mycroft.mozdev.org/search-engines.html

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/73b696d6aa02

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101117 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 8

[Ayan Shah[:ashah]]

Similar to test case:

https://litmus.mozilla.org/show_test.cgi?id=15031