605089 - Remove uses of the sortDirectionIndicator class

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

I failed to figure out when it became obsolete, but sortDirectionIndicator isn't doing anything.

https://developer.mozilla.org/en/XUL_Tutorial/Trees_and_Templates#Sorting_Columns states: "Although the sorting will function correctly with only those attributes, you may also use the style class sortDirectionIndicator on a column that can be sorted. This will cause a small triangle to appear on the column header that indicates the direction of the sort. If you don't do this, the user may still sort the columns but will have no indication as to which column is currently sorted."
This is false. The indicator depends on the sortDirection attribute.

Comment 1

[Phil Ringnalda (:philor)]

(In reply to comment #0)
> I failed to figure out when it became obsolete

March 2002, in http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/themes/classic/global/win/tree.css&rev=1.37, looks like.

Comment 2

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/a4f258937f3f

Comment 3

[Eric Shepherd [:sheppy]]

Removed obsolete references to setDirectionIndicator in https://developer.mozilla.org/en/XUL_Tutorial/Trees_and_Templates

Mentioned this on Fx4 for developers.