Remove uses of the sortDirectionIndicator class

RESOLVED FIXED in mozilla2.0b7

Status

()

Toolkit
XUL Widgets
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({dev-doc-complete})

Trunk
mozilla2.0b7
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 483926 [details] [diff] [review]
patch

I failed to figure out when it became obsolete, but sortDirectionIndicator isn't doing anything.

https://developer.mozilla.org/en/XUL_Tutorial/Trees_and_Templates#Sorting_Columns states: "Although the sorting will function correctly with only those attributes, you may also use the style class sortDirectionIndicator on a column that can be sorted. This will cause a small triangle to appear on the column header that indicates the direction of the sort. If you don't do this, the user may still sort the columns but will have no indication as to which column is currently sorted."
This is false. The indicator depends on the sortDirection attribute.
Attachment #483926 - Flags: review?(enndeakin)
(Assignee)

Updated

8 years ago
Severity: trivial → normal
(Assignee)

Updated

8 years ago
Component: General → XUL Widgets
QA Contact: general → xul.widgets
(In reply to comment #0)
> I failed to figure out when it became obsolete

March 2002, in http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/themes/classic/global/win/tree.css&rev=1.37, looks like.

Updated

8 years ago
Attachment #483926 - Flags: review?(enndeakin) → review+
(Assignee)

Updated

8 years ago
Attachment #483926 - Flags: approval2.0?
Attachment #483926 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/a4f258937f3f
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Removed obsolete references to setDirectionIndicator in https://developer.mozilla.org/en/XUL_Tutorial/Trees_and_Templates

Mentioned this on Fx4 for developers.
Keywords: dev-doc-needed → dev-doc-complete

Updated

8 years ago
No longer blocks: 467530
Blocks: 605381
No longer blocks: 606804
(Assignee)

Updated

8 years ago
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.