605125 - Add :-moz-ui-valid pseudo-class

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Mounir Lamouri (:mounir)]

This is going to be very similar to bug 605124 but for :valid.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Part 1 - Add :-moz-ui-valid pseudo-class

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 488907 [details] [diff] [review]
Part 1 - Add :-moz-ui-valid pseudo-class

r=me

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Part 2 - Make :-moz-ui-valid follow rules for :valid

Comment 4

[Mounir Lamouri (:mounir)]

I've an idea of what :-moz-ui-valid should be but I prefer to be sure limi and Jonas agree before asking reviews.

The idea is to make :-moz-ui-valid apply when:
1. the element is valid
2. the element has it's value changed or the form has been submitted

When typing, we should dynamically change the style if the element was invalid on focus. Otherwise, we should keep the current style.

IOW, there are 3 situations:
1. you focus a field which hasn't :-moz-ui-invalid nor :-moz-ui-valid applied, in that case, one of them will apply on blur if the value has been changed ;
2. you focus a field which has :-moz-ui-valid applied, in that case one of the two pseudo-class will apply to reflect the new state on blur ;
3. you focus a field which has :-moz-ui-invalid applied, in that case the style will dynamically change will typing.

Let me know if you think we can go with that.

Comment 5

[Mounir Lamouri (:mounir)]

Comment on attachment 489210 [details] [diff] [review]
Part 2 - Make :-moz-ui-valid follow rules for :valid

Boris, feel free to ignore the review if it should take you too much time given that I didn't got a real feedback. However, I think my proposal should make sense and I will write the patches.

Comment 6

[Mounir Lamouri (:mounir)]

Attachment: Part 3 - :-moz-ui-valid doesn't apply if the element hasn't been modified

Lot of tests but very small changes in the code.

Comment 7

[Mounir Lamouri (:mounir)]

Attachment: Part 4 - :-moz-ui-valid applies if the user tried to submit the form in an invalid state

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 489210 [details] [diff] [review]
Part 2 - Make :-moz-ui-valid follow rules for :valid

r=me

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 489494 [details] [diff] [review]
Part 3 - :-moz-ui-valid doesn't apply if the element hasn't been modified

r=me

Comment 10

[Mounir Lamouri (:mounir)]

Attachment: Part 5 - :-moz-ui-valid should not apply while typing if the element had no style when it was focused

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 489503 [details] [diff] [review]
Part 4 - :-moz-ui-valid applies if the user tried to submit the form in an invalid state

r=me

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 489542 [details] [diff] [review]
Part 5 - :-moz-ui-valid should not apply while typing if the element had no style when it was focused

>+      // If nor invalid UI nor valid UI is shown, we shouldn't show the valid
>+      // UI while typing.

  If neither ... nor ....

Maybe rename BF_DONT_SHOW_VALID_UI to BF_SUPPRESS_VALID_UI?

>+    // :-moz-ui-valid should never apply if when the element was focused,

Need comma before "when".  

>+    // 1. the element is valid, and

This "and" doesn't match the || in the code.  Which is correct?

>+    // 2. the element shouldn't show the invalid ui (and isn't valid).

I don't understand what this is trying to say.

It looks like whether we have NS_EVENT_STATE_MOZ_UI_VALID depends on the value of BF_CAN_SHOW_INVALID_UI.  When the latter changes, do we do a ContentStatesChanged for the former?

The multipart comment is really hard to read, as is the code that follows it.... (esp. because the second 1&2 pair doesn't map to an actual || in the code, as far as I can see).

>+   * Return if an element should show the valid UI.

s/if/whether/

ShouldShowValidUI might be better named as CanShowValidUI, no?

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment 4 sounds good to me.

Comment 14

[Mounir Lamouri (:mounir)]

Attachment: Part 5 - :-moz-ui-valid should not apply while typing if the element had no style when it was focused

I tried to make things clearer by using the same name that I used for :-moz-ui-invalid and changed the comments.

Comment 15

[Boris Zbarsky [:bzbarsky]]

The comment for mCanShowValidUI looks like it needs updating.

I still don't understand the long -moz-ui-valid comments.  Please catch me on irc so we can talk about them?

Comment 16

[Mounir Lamouri (:mounir)]

Attachment: Part 5 - :-moz-ui-valid should not apply while typing if the element had no style when it was focused

With comments fixed.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 490602 [details] [diff] [review]
Part 5 - :-moz-ui-valid should not apply while typing if the element had no style when it was focused

>+    // :-moz-ui-valid applies if:

Needs "all of the following are true".

r=me with that fixed

Comment 18

[Alex Limi (:limi) — Firefox UX Team]

Hard for me to test all these cases, but generally seems to be doing the right thing. Was asked for informal feedback, so here it is. Let's get it in a beta and get some feedback on it. :)

Comment 19

[Johnny Stenback (:jst)]

Comment on attachment 490602 [details] [diff] [review]
Part 5 - :-moz-ui-valid should not apply while typing if the element had no style when it was focused

a=jst for this series of changes.

Comment 20

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/27db143745a7
http://hg.mozilla.org/mozilla-central/rev/a5443d86c431
http://hg.mozilla.org/mozilla-central/rev/b47d30240391
http://hg.mozilla.org/mozilla-central/rev/8761f71f04b5
http://hg.mozilla.org/mozilla-central/rev/c2d742db6304

Comment 21

[Janet Swisher]

Assigning to me for doc.

Comment 22

[Janet Swisher]

Documented at: https://developer.mozilla.org/en/CSS/:-moz-ui-valid