605242 - No :active state for <button>

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Click button.

Expected: Turn blue while the mouse button is down, so I can tell I clicked it.
Result: No visual change.

Regression from the recent focus changes, perhaps?  (Bug 418521, bug 564277)

Comment 1

[Neil Deakin]

Unlikely, as this bug doesn't look focus related. And I don't see the bug in a build from October 13, so this is a recent regression.

Bug 582771 is more likely.

The only Mac bug that might be related is bug 587418.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Looking.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This should do it, but I don't really like the API anymore.
But perhaps I could make a better API in a followup?

And ofc, this needs tests!

Comment 4

[Neil Deakin]

Comment on attachment 484105 [details] [diff] [review]
patch

Looks ok, but it might be more readable to just pass the prescontext to SetGlobalActiveContent and have the ugly-looking cast for the ESM only once inside.

Or maybe even make SetGlobalActiveContent non-static.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I'll file a followup to handle the globalness of ESM inside ESM, well
if that is easily doable.
But that might be post FF4 work.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: with a test

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/91a2567620be

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

I had to backout part of the patch to fix the regression
http://hg.mozilla.org/mozilla-central/rev/d5623a818b55

I'll investigate the reason for the regression.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

This bug (:active state for button) should be still fixed though.

Comment 10

[Alice0775 White]

This bug causes the following regression,
See; https://bugzilla.mozilla.org/show_bug.cgi?id=603550#c21